SerializesModels's firstOrFail doesn't honor $tries

[alejandrovelez7]

Laravel Version

9.52.16

PHP Version

8.1.29

Database Driver & Version

No response

Description

Context

When a job uses SerializesModels the firstOrFail here doesn't allow the job to retry.

We occasionally run into connection issues like (SQLSTATE[HY000] [2002] Operation now in progress) with our database while processing jobs, and these don't indicate the model itself doesn't exist. We'd like to be able to retry the job in this case.

If we upgrade to 11.24.0 will we no longer experience this because we'll have #52759 ?

Steps To Reproduce

For a simple example, I'm using Spatie's laravel webhook client which uses SerializesModels for the WebhookCall in their jobs.

We can extend their webhook job like so ->

<?php
use Exception;
use Spatie\WebhookClient\Jobs\ProcessWebhookJob;
use Spatie\WebhookClient\Models\WebhookCall;


class ProcessCoolWebhookJob extends ProcessWebhookJob
{
    public int $tries = 3;

    public function __construct(
        public WebhookCall $webhookCall
    ) {
        parent::__construct($webhookCall);
    }
    
    public function handle(): void
    {
        throw new Exception('This is a test exception');
    }
}

If we dispatch this job onto a horizon queue via ProcessWebhookJob::dispatch(new Spatie\WebhookClient\Models\WebhookCall()) the model will not be found, but the tries will not be honored, and the job will go straight into failed_jobs.

This seems like a design choice (which is fine), but what's the workaround for this? I've attempted to override the failed function, but it is not being called.

I've also tried to include custom middleware like this:

<?php
namespace App\Domains\WMS\Jobs;

use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Support\Facades\Log;
use Throwable;

class JobFailedMiddleware
{
    public function handle($job, $next)
    {
        try {
            logger()->info('Hit the job failed middleware');
            $next($job);
        } catch (ModelNotFoundException $e) {
            // Handle the deserialization failure
            Log::error('Model deserialization failed', [
                'job' => get_class($job),
                'exception' => $e->getMessage(),
            ]);

            // Retry or delete the job
            $job->release(10); // Retry after 10 seconds
        } catch (Throwable $e) {
            Log::error('Unexpected error during job deserialization', [
                'job' => get_class($job),
                'exception' => $e->getMessage(),
            ]);

            // Let the job fail
            throw $e;
        }
    }
}

But this is also not being called on failures.