Update model props in "deleting" event not working as expected

[ryanmortier]

Laravel Version

11.37.0

PHP Version

8.3.15

Database Driver & Version

No response

Description

Similar to #31754

I am using the deleting event like so:

class WorkOrderObserver
{
    public function deleting(WorkOrder $workOrder): void
    {
        $workOrder->status = WorkOrderStatus::Deleted;
    }
}

Unfortunately, the status is not being updated when the model is persisted. I've verified the event is being hit by dumping/logging the model inside the method.

In any of the other events ending with ing (creating, updating, restoring), I can update a property on the model before it's persisted. For example, I'm doing this with the restoring event and it's working:

    public function restoring(WorkOrder $workOrder): void
    {
        $workOrder->status = WorkOrderStatus::Open;
    }

It's only the deleting event that this doesn't work. I'm trying to avoid doing a second database query to update the status when the model is soft-deleted.

The second query isn't that big of a deal unless you have a bulk delete feature and then you have n*2 queries. For example:

The restoring event does one query:

update [maintenance].[work_orders] set [status] = 'Open', [deleted_at] = null, [maintenance].[work_orders].[updated_at] = '2024-11-27 18:42:29.688' where [id] = '1'

While the deleting event, I'm forced to put a $workOrder->save() at the end of the event method to persist the change which causes two queries:

update [maintenance].[work_orders] set [status] = 'Deleted', [maintenance].[work_orders].[updated_at] = '2024-11-27 18:47:23.486' where [id] = '1'
update [maintenance].[work_orders] set [deleted_at] = '2024-11-27 18:47:23.527', [maintenance].[work_orders].[updated_at] = '2024-11-27 18:47:23.527' where [id] = '1'

Steps To Reproduce

1. Clone: https://github.com/ryanmortier/laravel-deleting-event-bug
2. Run tests

[cosmastech]

To make this work, I believe it would require the $columns in SoftDeletes@runSoftDelete() to merge the existing dirty attributes. https://github.com/laravel/framework/blob/11.x/src/Illuminate/Database/Eloquent/SoftDeletes.php#L143

Not sure if that would be accepted, happy to take a stab at it if this gets marked as "Help Wanted." In the interim, you could make your own SoftDeletes trait that override just that single function

trait SoftDeletesTrait
{
    use SoftDeletes;

    protected function runSoftDelete()
    {
        $query = $this->setKeysForSaveQuery($this->newModelQuery());

        $time = $this->freshTimestamp();

        /**
         * I haven't tested this, but here we are merging the dirty columns + the deleted_at column
         */
        $columns = $this->getDirty() + [$this->getDeletedAtColumn() => $this->fromDateTime($time)];

        $this->{$this->getDeletedAtColumn()} = $time;

        if ($this->usesTimestamps() && ! is_null($this->getUpdatedAtColumn())) {
            $this->{$this->getUpdatedAtColumn()} = $time;

            $columns[$this->getUpdatedAtColumn()] = $this->fromDateTime($time);
        }

        $query->update($columns);

        $this->syncOriginalAttributes(array_keys($columns));

        $this->fireModelEvent('trashed', false);
    }
}

[ryanmortier]

Thanks, I'll give this a go since it doesn't look like this is considered a "bug".

[ryanmortier]

Update, this is working great by the way. It honestly should be added to core to make the deleting event work consistently like the other "ing" events.