Static macro call that calls another static macro: Warning: Cannot unbind $this of closure using $this

[cosmastech]

Laravel Version

11.41.2

PHP Version

8.3

Database Driver & Version

n/a

Description

Not sure at what version of PHP this would've started happening, but in my production code, I get the following warning:

Warning: Cannot unbind $this of closure using $this in /Users/luke/Projects/laravel-framework/src/Illuminate/Macroable/Traits/Macroable.php on line 97

Steps To Reproduce

To reproduce:

class MyClass
{
  use Macroable;
}

class MyOtherClass
{
  use Macroable;
}

MyClass::macro('getAString', function() { return $this::class; });
MyOtherClass::macro('concatTheStrings', function() { return 'hello' . MyClass::getAString(); });
MyOtherClass::concatTheStrings();

One possible solution is inside of Macroable::__callStatic() to build an instance of the class from the container, rather than binding it to null.

trait Macroable
{
    // ...
    public static function __callStatic($method, $parameters)
    {
        if (! static::hasMacro($method)) {
            throw new BadMethodCallException(sprintf(
                'Method %s::%s does not exist.', static::class, $method
            ));
        }

        $macro = static::$macros[$method];

        if ($macro instanceof Closure) {
--          $macro = $macro->bindTo(null, static::class);
++          $macro = $macro->bindTo(app(static::class), static::class);
        }

        return $macro(...$parameters);
    }
}

though I think that's a bit inelegant, clunky, and admittedly I don't know all the ramifications of it.

[macropay-solutions]

If you use $this in the macro you can't call it as static.
https://medium.com/@sirajul.anik/laravel-macroable-understanding-macros-and-mixin-1c3aaa9f8ba8

[cosmastech]

Thanks! In a fog, I didn't realize that I had previously made this macro:

use Illuminate\Database\Schema\Builder;

Builder::macro('getCaseSensitiveCollation', function () {
    if ($this->getConnection() instanceof MySqlBuilder) {
        return 'utf8mb4_bin';
    }

    return $this->getConnection()->getConfig('collation');
});

Where it works with \Schema::getCaseSensitiveCollation() but not Builder::getCaseSensitiveCollation(). 🤦