Bug 'In' rule validation when validating string with numeric values

[abduromanov]

Laravel Version

11.3.4

PHP Version

8.3.15

Database Driver & Version

No response

Description

I need rules to validate string value with identical numeric value like 001. I put Rule::in(['001', '002']) on my application. When testing with value like 01, 1 or add multiple 0 as suffix it will be passed. It should break the validation and returning error response.

Steps To Reproduce

routes/api.php

Route::post('/test', function (Request $request) {
    $data = $request->validate([
        'code' => ['required', Rule::in('001', '002')],
    ]);

    return response()->json($data);
});

tests/ExampleTest.php

it('should fails validation', function () {
    postJson('/api/test', ['code' => '1'])->assertUnprocessable();
});

it('should pass validation', function () {
    postJson('/api/test', ['code' => '001'])->assertOk();
});

The should fails validation is returning 200 instead 422 and the second test there's no problem.

[crynobone]

The validation is done using in_array('1', ['001', '002']) which would return true.

It might be best to create a custom rule for this purpose.

[abduromanov]

I think it will better if this rule make in_array strict parameter to be true just to make it type safe

[crynobone]

That can easily broken existing applications if the rule is currently defined not to be strict.

[ghost]

Strict will break when int is sent and '1' is expected because of the explode by comma that is applied on the rule.