Redis cluster issue solved, but Laravel docs was missing information or a class method is mapping variables incorrect

[zebamba]

I had an issue with phpredis

phpredis - Couldn't map cluster keyspace using any provided seed Solved

Based on the Laravel documentation to set up a Redis cluster connection the config should look like:

'redis' => [

    'client' => env('REDIS_CLIENT', 'phpredis'),

    'options' => [
        'cluster' => env('REDIS_CLUSTER', 'redis'),
        'prefix' => env('REDIS_PREFIX', Str::slug(env('APP_NAME', 'laravel'), '_').'_database_'),
    ],

    'clusters' => [
        'default' => [
            [
                'url' => env('REDIS_URL'),
                'host' => env('REDIS_HOST', '127.0.0.1'),
                'username' => env('REDIS_USERNAME'),
                'password' => env('REDIS_PASSWORD'),
                'port' => env('REDIS_PORT', '6379'),
                'database' => env('REDIS_DB', '0'),
            ],
        ],
    ],

    // ...
],

I had to setup Redis cluster with phpredis fwith ACL authentication.

The issue I found is when calling method createRedisClusterInstance on PhpRedisConnector class

return tap(new RedisCluster(...$parameters) ...

The fifth argument auth on variable $parameters is set as null.

To solve the issue I had to change my configuration

'redis' => [

        'client' => env('REDIS_CLIENT', 'phpredis'),

        'options' => [
            'cluster' => env('REDIS_CLUSTER', 'redis'),
            'prefix' => env('REDIS_PREFIX', 'my_prefix:'),
            'password' => env('REDIS_USERNAME', null) ? [env('REDIS_USERNAME', null), env('REDIS_PASSWORD', null)] : env('REDIS_PASSWORD', null),
        ],

        'clusters' => [
            'default' => [
                [
                    'host' => env('REDIS_HOST_1', '127.0.0.1'),
                    'username' => env('REDIS_USERNAME', null),
                    'password' => env('REDIS_PASSWORD', null),
                    'port' => env('REDIS_PORT', '6379'),
                    'database' => env('REDIS_DB', '0'),
                    'persistent' => true,
                ],
                [
                    'host' => env('REDIS_HOST_2', '127.0.0.1'),
                    'username' => env('REDIS_USERNAME', null),
                    'password' => env('REDIS_PASSWORD', null),
                    'port' => env('REDIS_PORT', '6379'),
                    'database' => env('REDIS_DB', '0'),
                    'persistent' => true,
                ],
                [
                    'host' => env('REDIS_HOST_3', '127.0.0.1'),
                    'username' => env('REDIS_USERNAME', null),
                    'password' => env('REDIS_PASSWORD', null),
                    'port' => env('REDIS_PORT', '6379'),
                    'database' => env('REDIS_DB', '0'),
                    'persistent' => true,
                ],
            ],
        ],

    ],

Also as if you noticed 'persistent' => true, should be inside of each cluster.

Question:

Does the docs should be updated or the class that generates the mapping for the variable $parameters corrected?