You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't know where to share this exactly, but the response's json() method signature change is a breaking change.
I left a comment in the PR itself, but I think it was lost due to the PR being merged already.
The problematic part is that if a package supports multiple versions of Laravel and happens to be providing a custom response will have to work around this in non-conventional ways.
This is clearly not something that will affect the majority of the ecosystem, but I think it is good to acknowledge it in the release notes somehow, so people are aware.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I don't know where to share this exactly, but the response's
json()method signature change is a breaking change.I left a comment in the PR itself, but I think it was lost due to the PR being merged already.
The problematic part is that if a package supports multiple versions of Laravel and happens to be providing a custom response will have to work around this in non-conventional ways.
This is clearly not something that will affect the majority of the ecosystem, but I think it is good to acknowledge it in the release notes somehow, so people are aware.
Beta Was this translation helpful? Give feedback.
All reactions