Add PHPStan and configuration (#1947)

Author: svpernova09

.github/workflows/tests.yml

@@ -38,5 +38,8 @@ jobs:
       - name: Install dependencies
         run: composer install --prefer-dist --no-interaction --no-progress
 
+      - name: Run PhpStan
+        run: vendor/bin/phpstan analyse src tests
+
       - name: Execute tests
         run: vendor/bin/phpunit --verbose

composer.json

@@ -9,7 +9,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5",
-        "dms/phpunit-arraysubset-asserts": "^0.2.1"
+        "dms/phpunit-arraysubset-asserts": "^0.2.1",
+        "phpstan/phpstan": "^1.10"
     },
     "license": "MIT",
     "authors": [

composer.lock

@@ -0,0 +1,17 @@
+parameters:
+  paths:
+    - src
+  level: 0
+  ignoreErrors:
+    - "#\\(void\\) is used#"
+    - "#Access to an undefined property#"
+    - "#Call to an undefined method#"
+    - "#but return statement is missing.#"
+    - "#Caught class [a-zA-Z0-9\\\\_]+ not found.#"
+    - "#Class [a-zA-Z0-9\\\\_]+ not found.#"
+    - "#has invalid type#"
+    - "#should always throw an exception or terminate script execution#"
+    - "#Instantiated class [a-zA-Z0-9\\\\_]+ not found.#"
+    - "#Unsafe usage of new static#"
+  excludePaths:
+    - "src/Illuminate/Testing/ParallelRunner.php"

phpstan.src.neon.dist

@@ -2,7 +2,7 @@
 
 namespace Laravel\Homestead\Settings;
 
-class JsonSettings extends HomesteadSettings
+final class JsonSettings extends HomesteadSettings
 {
     /**
      * Create an instance from a file.

src/Settings/JsonSettings.php

@@ -4,7 +4,7 @@
 
 use Symfony\Component\Yaml\Yaml;
 
-class YamlSettings extends HomesteadSettings
+final class YamlSettings extends HomesteadSettings
 {
     /**
      * Create an instance from a file.