fix: valet with no paths configured (#388)

* fix: valet with no paths configured

* refactor: fix style

* refactor: rename test file

* refactor: remove return types

* Update InteractsWithHerdOrValet.php

---------

Co-authored-by: Taylor Otwell <[email protected]>

Author: almontasser

src/Concerns/InteractsWithHerdOrValet.php

@@ -17,7 +17,9 @@ public function isParkedOnHerdOrValet(string $directory)
     {
         $output = $this->runOnValetOrHerd('paths');
 
-        return $output !== false ? in_array(dirname($directory), json_decode($output)) : false;
+        $decodedOutput = json_decode($output);
+
+        return is_array($decodedOutput) && in_array(dirname($directory), $decodedOutput);
     }
 
     /**

tests/InteractsWithHerdOrValetTest.php

@@ -0,0 +1,20 @@
+<?php
+
+use Laravel\Installer\Console\Concerns\InteractsWithHerdOrValet;
+use PHPUnit\Framework\TestCase;
+
+class InteractsWithHerdOrValetTest extends TestCase
+{
+    use InteractsWithHerdOrValet;
+
+    public function test_isParkedOnHerdOrValet_returns_false_when_output_is_not_json()
+    {
+        $mockProcess = $this->getMockBuilder(\Symfony\Component\Process\Process::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $mockProcess->method('isSuccessful')->willReturn(true);
+        $mockProcess->method('getOutput')->willReturn('No paths have been registered.');
+
+        $this->assertFalse($this->isParkedOnHerdOrValet('paths'));
+    }
+}