[4.x] Fix multiple issues when running on Windows. (#133)

* fix

* Remove .idea/ from gitignore

* Fixes for running installer on Windows.

* Fix tests on Windows.

Co-authored-by: ExpDev07 <[email protected]>
Co-authored-by: ExpDev <[email protected]>

Author: 3 people

.github/workflows/tests.yml

@@ -7,7 +7,7 @@ on:
     - cron: '0 0 * * *'
 
 jobs:
-  tests:
+  linux_tests:
 
     runs-on: ubuntu-latest
     strategy:
@@ -34,3 +34,37 @@ jobs:
 
       - name: Execute tests
         run: vendor/bin/phpunit --verbose
+
+  windows_tests:
+
+    runs-on: windows-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        php: [7.3, 7.4]
+
+    name: PHP ${{ matrix.php }} - Windows
+
+    steps:
+      - name: Set git to use LF
+        run: |
+          git config --global core.autocrlf false
+          git config --global core.eol lf
+
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          extensions: dom, curl, libxml, mbstring, zip
+          tools: composer:v2
+          coverage: none
+          ini-values: memory_limit=512M
+
+      - name: Install dependencies
+        run: composer install --no-interaction --prefer-dist
+
+      - name: Execute tests
+        run: vendor/bin/phpunit --verbose

src/NewCommand.php

@@ -83,11 +83,18 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $commands = [
             $composer." create-project laravel/laravel $directory $version --remove-vcs --prefer-dist",
-            "chmod 644 $directory/artisan",
         ];
 
-        if ($directory != '.') {
-            array_unshift($commands, "rm -rf $directory");
+        if ($directory != '.' && $input->getOption('force')) {
+            if (PHP_OS_FAMILY == 'Windows') {
+                array_unshift($commands, "rd /s /q \"$directory\"");
+            } else {
+                array_unshift($commands, "rm -rf $directory");
+            }
+        }
+
+        if (PHP_OS_FAMILY != 'Windows') {
+            $commands[] = "chmod 644 $directory/artisan";
         }
 
         if ($this->runCommands($commands, $input, $output)->isSuccessful()) {

tests/NewCommandTest.php

@@ -14,7 +14,13 @@ public function test_it_can_scaffold_a_new_laravel_app()
         $scaffoldDirectoryName = 'tests-output/my-app';
         $scaffoldDirectory = __DIR__.'/../'.$scaffoldDirectoryName;
 
-        exec("rm -rf $scaffoldDirectory");
+        if (file_exists($scaffoldDirectory)) {
+            if (PHP_OS_FAMILY == 'Windows') {
+                exec("rd /s /q \"$scaffoldDirectory\"");
+            } else {
+                exec("rm -rf $scaffoldDirectory");
+            }
+        }
 
         $app = new Application('Laravel Installer');
         $app->add(new NewCommand);