[4.x] Fix Browser Sessions not showing platform and browser (#1412)

* use simple key value store

* Add failing tests for PR #1412

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>

---------

Signed-off-by: Mior Muhammad Zaki <[email protected]>
Co-authored-by: Mior Muhammad Zaki <[email protected]>

Author: olumby

src/Agent.php

@@ -3,8 +3,6 @@
 namespace Laravel\Jetstream;
 
 use Closure;
-use Detection\Cache\CacheException;
-use Detection\Exception\MobileDetectException;
 use Detection\MobileDetect;
 
 /**
@@ -50,6 +48,13 @@ class Agent extends MobileDetect
         'WeChat' => 'MicroMessenger',
     ];
 
+    /**
+     * Key value store for resolved strings.
+     *
+     * @var array<string, mixed>
+     */
+    protected $store = [];
+
     /**
      * Get the platform name from the User Agent.
      *
@@ -126,24 +131,18 @@ protected function findDetectionRulesAgainstUserAgent(array $rules)
      * @param  string  $key
      * @param  \Closure():mixed  $callback
      * @return mixed
-     *
-     * @throws \Detection\Exception\MobileDetectException
      */
     protected function retrieveUsingCacheOrResolve(string $key, Closure $callback)
     {
-        try {
-            $cacheKey = $this->createCacheKey($key);
+        $cacheKey = $this->createCacheKey($key);
 
-            if (! is_null($cacheItem = $this->cache->get($cacheKey))) {
-                return $cacheItem->get();
-            }
-
-            return tap(call_user_func($callback), function ($result) use ($cacheKey) {
-                $this->cache->set($cacheKey, $result);
-            });
-        } catch (CacheException $e) {
-            throw new MobileDetectException("Cache problem in for {$key}: {$e->getMessage()}");
+        if (! is_null($cacheItem = $this->store[$cacheKey] ?? null)) {
+            return $cacheItem;
         }
+
+        return tap(call_user_func($callback), function ($result) use ($cacheKey) {
+            $this->store[$cacheKey] = $result;
+        });
     }
 
     /**

tests/AgentTest.php

@@ -22,7 +22,10 @@ public function testOperatingSystems($userAgent, $platform)
         $agent = new Agent();
         $agent->setUserAgent($userAgent);
 
-        $this->assertEquals($platform, $agent->platform());
+        $this->assertSame($platform, $agent->platform());
+
+        // Test cached value return the same output.
+        $this->assertSame($platform, $agent->platform());
     }
 
     public static function operatingSystemsDataProvider()
@@ -48,7 +51,10 @@ public function testBrowsers($userAgent, $browser)
         $agent = new Agent();
         $agent->setUserAgent($userAgent);
 
-        $this->assertEquals($browser, $agent->browser());
+        $this->assertSame($browser, $agent->browser());
+
+        // Test cached value return the same output.
+        $this->assertSame($browser, $agent->browser());
     }
 
     public static function browsersDataProvider()