Remove unused variables from test stubs (#1480)

alsterholm · web-flow · commit 2ee2c38e9416 · 2024-04-29T08:25:38.000-05:00
diff --git a/stubs/pest-tests/inertia/ApiTokenPermissionsTest.php b/stubs/pest-tests/inertia/ApiTokenPermissionsTest.php
@@ -17,7 +17,7 @@
         'abilities' => ['create', 'read'],
     ]);
 
-    $response = $this->put('/user/api-tokens/'.$token->id, [
+    $this->put('/user/api-tokens/'.$token->id, [
         'name' => $token->name,
         'permissions' => [
             'delete',
diff --git a/stubs/pest-tests/inertia/BrowserSessionsTest.php b/stubs/pest-tests/inertia/BrowserSessionsTest.php
@@ -3,7 +3,7 @@
 use App\Models\User;
 
 test('other browser sessions can be logged out', function () {
-    $this->actingAs($user = User::factory()->create());
+    $this->actingAs(User::factory()->create());
 
     $response = $this->delete('/user/other-browser-sessions', [
         'password' => 'password',
diff --git a/stubs/pest-tests/inertia/CreateApiTokenTest.php b/stubs/pest-tests/inertia/CreateApiTokenTest.php
@@ -10,7 +10,7 @@
         $this->actingAs($user = User::factory()->create());
     }
 
-    $response = $this->post('/user/api-tokens', [
+    $this->post('/user/api-tokens', [
         'name' => 'Test Token',
         'permissions' => [
             'read',
diff --git a/stubs/pest-tests/inertia/CreateTeamTest.php b/stubs/pest-tests/inertia/CreateTeamTest.php
@@ -5,7 +5,7 @@
 test('teams can be created', function () {
     $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-    $response = $this->post('/teams', [
+    $this->post('/teams', [
         'name' => 'Test Team',
     ]);
 
diff --git a/stubs/pest-tests/inertia/DeleteAccountTest.php b/stubs/pest-tests/inertia/DeleteAccountTest.php
@@ -6,7 +6,7 @@
 test('user accounts can be deleted', function () {
     $this->actingAs($user = User::factory()->create());
 
-    $response = $this->delete('/user', [
+    $this->delete('/user', [
         'password' => 'password',
     ]);
 
@@ -18,7 +18,7 @@
 test('correct password must be provided before account can be deleted', function () {
     $this->actingAs($user = User::factory()->create());
 
-    $response = $this->delete('/user', [
+    $this->delete('/user', [
         'password' => 'wrong-password',
     ]);
 
diff --git a/stubs/pest-tests/inertia/DeleteApiTokenTest.php b/stubs/pest-tests/inertia/DeleteApiTokenTest.php
@@ -17,7 +17,7 @@
         'abilities' => ['create', 'read'],
     ]);
 
-    $response = $this->delete('/user/api-tokens/'.$token->id);
+    $this->delete('/user/api-tokens/'.$token->id);
 
     expect($user->fresh()->tokens)->toHaveCount(0);
 })->skip(function () {
diff --git a/stubs/pest-tests/inertia/DeleteTeamTest.php b/stubs/pest-tests/inertia/DeleteTeamTest.php
@@ -14,7 +14,7 @@
         $otherUser = User::factory()->create(), ['role' => 'test-role']
     );
 
-    $response = $this->delete('/teams/'.$team->id);
+    $this->delete('/teams/'.$team->id);
 
     expect($team->fresh())->toBeNull();
     expect($otherUser->fresh()->teams)->toHaveCount(0);
@@ -23,7 +23,7 @@
 test('personal teams cant be deleted', function () {
     $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-    $response = $this->delete('/teams/'.$user->currentTeam->id);
+    $this->delete('/teams/'.$user->currentTeam->id);
 
     expect($user->currentTeam->fresh())->not->toBeNull();
 });
diff --git a/stubs/pest-tests/inertia/InviteTeamMemberTest.php b/stubs/pest-tests/inertia/InviteTeamMemberTest.php
@@ -10,7 +10,7 @@
 
     $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-    $response = $this->post('/teams/'.$user->currentTeam->id.'/members', [
+    $this->post('/teams/'.$user->currentTeam->id.'/members', [
         'email' => 'test@example.com',
         'role' => 'admin',
     ]);
@@ -32,7 +32,7 @@
         'role' => 'admin',
     ]);
 
-    $response = $this->delete('/team-invitations/'.$invitation->id);
+    $this->delete('/team-invitations/'.$invitation->id);
 
     expect($user->currentTeam->fresh()->teamInvitations)->toHaveCount(0);
 })->skip(function () {
diff --git a/stubs/pest-tests/inertia/LeaveTeamTest.php b/stubs/pest-tests/inertia/LeaveTeamTest.php
@@ -11,7 +11,7 @@
 
     $this->actingAs($otherUser);
 
-    $response = $this->delete('/teams/'.$user->currentTeam->id.'/members/'.$otherUser->id);
+    $this->delete('/teams/'.$user->currentTeam->id.'/members/'.$otherUser->id);
 
     expect($user->currentTeam->fresh()->users)->toHaveCount(0);
 });
diff --git a/stubs/pest-tests/inertia/ProfileInformationTest.php b/stubs/pest-tests/inertia/ProfileInformationTest.php
@@ -5,7 +5,7 @@
 test('profile information can be updated', function () {
     $this->actingAs($user = User::factory()->create());
 
-    $response = $this->put('/user/profile-information', [
+    $this->put('/user/profile-information', [
         'name' => 'Test Name',
         'email' => 'test@example.com',
     ]);
diff --git a/stubs/pest-tests/inertia/RemoveTeamMemberTest.php b/stubs/pest-tests/inertia/RemoveTeamMemberTest.php
@@ -9,7 +9,7 @@
         $otherUser = User::factory()->create(), ['role' => 'admin']
     );
 
-    $response = $this->delete('/teams/'.$user->currentTeam->id.'/members/'.$otherUser->id);
+    $this->delete('/teams/'.$user->currentTeam->id.'/members/'.$otherUser->id);
 
     expect($user->currentTeam->fresh()->users)->toHaveCount(0);
 });
diff --git a/stubs/pest-tests/inertia/TwoFactorAuthenticationSettingsTest.php b/stubs/pest-tests/inertia/TwoFactorAuthenticationSettingsTest.php
@@ -8,7 +8,7 @@
 
     $this->withSession(['auth.password_confirmed_at' => time()]);
 
-    $response = $this->post('/user/two-factor-authentication');
+    $this->post('/user/two-factor-authentication');
 
     expect($user->fresh()->two_factor_secret)->not->toBeNull();
     expect($user->fresh()->recoveryCodes())->toHaveCount(8);
diff --git a/stubs/pest-tests/inertia/UpdatePasswordTest.php b/stubs/pest-tests/inertia/UpdatePasswordTest.php
@@ -6,7 +6,7 @@
 test('password can be updated', function () {
     $this->actingAs($user = User::factory()->create());
 
-    $response = $this->put('/user/password', [
+    $this->put('/user/password', [
         'current_password' => 'password',
         'password' => 'new-password',
         'password_confirmation' => 'new-password',
diff --git a/stubs/pest-tests/inertia/UpdateTeamMemberRoleTest.php b/stubs/pest-tests/inertia/UpdateTeamMemberRoleTest.php
@@ -9,7 +9,7 @@
         $otherUser = User::factory()->create(), ['role' => 'admin']
     );
 
-    $response = $this->put('/teams/'.$user->currentTeam->id.'/members/'.$otherUser->id, [
+    $this->put('/teams/'.$user->currentTeam->id.'/members/'.$otherUser->id, [
         'role' => 'editor',
     ]);
 
@@ -27,7 +27,7 @@
 
     $this->actingAs($otherUser);
 
-    $response = $this->put('/teams/'.$user->currentTeam->id.'/members/'.$otherUser->id, [
+    $this->put('/teams/'.$user->currentTeam->id.'/members/'.$otherUser->id, [
         'role' => 'editor',
     ]);
 
diff --git a/stubs/pest-tests/inertia/UpdateTeamNameTest.php b/stubs/pest-tests/inertia/UpdateTeamNameTest.php
@@ -5,7 +5,7 @@
 test('team names can be updated', function () {
     $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-    $response = $this->put('/teams/'.$user->currentTeam->id, [
+    $this->put('/teams/'.$user->currentTeam->id, [
         'name' => 'Test Team',
     ]);
 
diff --git a/stubs/pest-tests/livewire/BrowserSessionsTest.php b/stubs/pest-tests/livewire/BrowserSessionsTest.php
@@ -5,7 +5,7 @@
 use Livewire\Livewire;
 
 test('other browser sessions can be logged out', function () {
-    $this->actingAs($user = User::factory()->create());
+    $this->actingAs(User::factory()->create());
 
     Livewire::test(LogoutOtherBrowserSessionsForm::class)
         ->set('password', 'password')
diff --git a/stubs/pest-tests/livewire/DeleteAccountTest.php b/stubs/pest-tests/livewire/DeleteAccountTest.php
@@ -8,7 +8,7 @@
 test('user accounts can be deleted', function () {
     $this->actingAs($user = User::factory()->create());
 
-    $component = Livewire::test(DeleteUserForm::class)
+    Livewire::test(DeleteUserForm::class)
         ->set('password', 'password')
         ->call('deleteUser');
 
diff --git a/stubs/pest-tests/livewire/DeleteTeamTest.php b/stubs/pest-tests/livewire/DeleteTeamTest.php
@@ -16,7 +16,7 @@
         $otherUser = User::factory()->create(), ['role' => 'test-role']
     );
 
-    $component = Livewire::test(DeleteTeamForm::class, ['team' => $team->fresh()])
+    Livewire::test(DeleteTeamForm::class, ['team' => $team->fresh()])
         ->call('deleteTeam');
 
     expect($team->fresh())->toBeNull();
@@ -26,7 +26,7 @@
 test('personal teams cant be deleted', function () {
     $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-    $component = Livewire::test(DeleteTeamForm::class, ['team' => $user->currentTeam])
+    Livewire::test(DeleteTeamForm::class, ['team' => $user->currentTeam])
         ->call('deleteTeam')
         ->assertHasErrors(['team']);
 
diff --git a/stubs/pest-tests/livewire/InviteTeamMemberTest.php b/stubs/pest-tests/livewire/InviteTeamMemberTest.php
@@ -12,7 +12,7 @@
 
     $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-    $component = Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
+    Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
         ->set('addTeamMemberForm', [
             'email' => 'test@example.com',
             'role' => 'admin',
diff --git a/stubs/pest-tests/livewire/LeaveTeamTest.php b/stubs/pest-tests/livewire/LeaveTeamTest.php
@@ -13,7 +13,7 @@
 
     $this->actingAs($otherUser);
 
-    $component = Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
+    Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
         ->call('leaveTeam');
 
     expect($user->currentTeam->fresh()->users)->toHaveCount(0);
@@ -22,7 +22,7 @@
 test('team owners cant leave their own team', function () {
     $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-    $component = Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
+    Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
         ->call('leaveTeam')
         ->assertHasErrors(['team']);
 
diff --git a/stubs/pest-tests/livewire/RemoveTeamMemberTest.php b/stubs/pest-tests/livewire/RemoveTeamMemberTest.php
@@ -11,7 +11,7 @@
         $otherUser = User::factory()->create(), ['role' => 'admin']
     );
 
-    $component = Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
+    Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
         ->set('teamMemberIdBeingRemoved', $otherUser->id)
         ->call('removeTeamMember');
 
@@ -27,7 +27,7 @@
 
     $this->actingAs($otherUser);
 
-    $component = Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
+    Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
         ->set('teamMemberIdBeingRemoved', $user->id)
         ->call('removeTeamMember')
         ->assertStatus(403);
diff --git a/stubs/pest-tests/livewire/UpdateTeamMemberRoleTest.php b/stubs/pest-tests/livewire/UpdateTeamMemberRoleTest.php
@@ -11,7 +11,7 @@
         $otherUser = User::factory()->create(), ['role' => 'admin']
     );
 
-    $component = Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
+    Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
         ->set('managingRoleFor', $otherUser)
         ->set('currentRole', 'editor')
         ->call('updateRole');
@@ -30,7 +30,7 @@
 
     $this->actingAs($otherUser);
 
-    $component = Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
+    Livewire::test(TeamMemberManager::class, ['team' => $user->currentTeam])
         ->set('managingRoleFor', $otherUser)
         ->set('currentRole', 'editor')
         ->call('updateRole')
diff --git a/stubs/tests/PasswordResetTest.php b/stubs/tests/PasswordResetTest.php
@@ -34,7 +34,7 @@ public function test_reset_password_link_can_be_requested(): void
 
         $user = User::factory()->create();
 
-        $response = $this->post('/forgot-password', [
+        $this->post('/forgot-password', [
             'email' => $user->email,
         ]);
 
@@ -51,7 +51,7 @@ public function test_reset_password_screen_can_be_rendered(): void
 
         $user = User::factory()->create();
 
-        $response = $this->post('/forgot-password', [
+        $this->post('/forgot-password', [
             'email' => $user->email,
         ]);
 
@@ -74,7 +74,7 @@ public function test_password_can_be_reset_with_valid_token(): void
 
         $user = User::factory()->create();
 
-        $response = $this->post('/forgot-password', [
+        $this->post('/forgot-password', [
             'email' => $user->email,
         ]);
 
diff --git a/stubs/tests/inertia/ApiTokenPermissionsTest.php b/stubs/tests/inertia/ApiTokenPermissionsTest.php
@@ -26,7 +26,7 @@ public function test_api_token_permissions_can_be_updated(): void
             'abilities' => ['create', 'read'],
         ]);
 
-        $response = $this->put('/user/api-tokens/'.$token->id, [
+        $this->put('/user/api-tokens/'.$token->id, [
             'name' => $token->name,
             'permissions' => [
                 'delete',
diff --git a/stubs/tests/inertia/BrowserSessionsTest.php b/stubs/tests/inertia/BrowserSessionsTest.php
@@ -12,7 +12,7 @@ class BrowserSessionsTest extends TestCase
 
     public function test_other_browser_sessions_can_be_logged_out(): void
     {
-        $this->actingAs($user = User::factory()->create());
+        $this->actingAs(User::factory()->create());
 
         $response = $this->delete('/user/other-browser-sessions', [
             'password' => 'password',
diff --git a/stubs/tests/inertia/CreateApiTokenTest.php b/stubs/tests/inertia/CreateApiTokenTest.php
@@ -19,7 +19,7 @@ public function test_api_tokens_can_be_created(): void
 
         $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-        $response = $this->post('/user/api-tokens', [
+        $this->post('/user/api-tokens', [
             'name' => 'Test Token',
             'permissions' => [
                 'read',
diff --git a/stubs/tests/inertia/CreateTeamTest.php b/stubs/tests/inertia/CreateTeamTest.php
@@ -14,7 +14,7 @@ public function test_teams_can_be_created(): void
     {
         $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-        $response = $this->post('/teams', [
+        $this->post('/teams', [
             'name' => 'Test Team',
         ]);
 
diff --git a/stubs/tests/inertia/DeleteAccountTest.php b/stubs/tests/inertia/DeleteAccountTest.php
@@ -19,7 +19,7 @@ public function test_user_accounts_can_be_deleted(): void
 
         $this->actingAs($user = User::factory()->create());
 
-        $response = $this->delete('/user', [
+        $this->delete('/user', [
             'password' => 'password',
         ]);
 
@@ -34,7 +34,7 @@ public function test_correct_password_must_be_provided_before_account_can_be_del
 
         $this->actingAs($user = User::factory()->create());
 
-        $response = $this->delete('/user', [
+        $this->delete('/user', [
             'password' => 'wrong-password',
         ]);
 
diff --git a/stubs/tests/inertia/DeleteApiTokenTest.php b/stubs/tests/inertia/DeleteApiTokenTest.php
@@ -26,7 +26,7 @@ public function test_api_tokens_can_be_deleted(): void
             'abilities' => ['create', 'read'],
         ]);
 
-        $response = $this->delete('/user/api-tokens/'.$token->id);
+        $this->delete('/user/api-tokens/'.$token->id);
 
         $this->assertCount(0, $user->fresh()->tokens);
     }
diff --git a/stubs/tests/inertia/DeleteTeamTest.php b/stubs/tests/inertia/DeleteTeamTest.php
@@ -23,7 +23,7 @@ public function test_teams_can_be_deleted(): void
             $otherUser = User::factory()->create(), ['role' => 'test-role']
         );
 
-        $response = $this->delete('/teams/'.$team->id);
+        $this->delete('/teams/'.$team->id);
 
         $this->assertNull($team->fresh());
         $this->assertCount(0, $otherUser->fresh()->teams);
@@ -33,7 +33,7 @@ public function test_personal_teams_cant_be_deleted(): void
     {
         $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-        $response = $this->delete('/teams/'.$user->currentTeam->id);
+        $this->delete('/teams/'.$user->currentTeam->id);
 
         $this->assertNotNull($user->currentTeam->fresh());
     }
diff --git a/stubs/tests/inertia/InviteTeamMemberTest.php b/stubs/tests/inertia/InviteTeamMemberTest.php
@@ -23,7 +23,7 @@ public function test_team_members_can_be_invited_to_team(): void
 
         $this->actingAs($user = User::factory()->withPersonalTeam()->create());
 
-        $response = $this->post('/teams/'.$user->currentTeam->id.'/members', [
+        $this->post('/teams/'.$user->currentTeam->id.'/members', [
             'email' => 'test@example.com',
             'role' => 'admin',
         ]);
@@ -48,7 +48,7 @@ public function test_team_member_invitations_can_be_cancelled(): void
             'role' => 'admin',
         ]);
 
-        $response = $this->delete('/team-invitations/'.$invitation->id);
+        $this->delete('/team-invitations/'.$invitation->id);
 
         $this->assertCount(0, $user->currentTeam->fresh()->teamInvitations);
     }
diff --git a/stubs/tests/inertia/LeaveTeamTest.php b/stubs/tests/inertia/LeaveTeamTest.php
diff --git a/stubs/tests/inertia/ProfileInformationTest.php b/stubs/tests/inertia/ProfileInformationTest.php
diff --git a/stubs/tests/inertia/RemoveTeamMemberTest.php b/stubs/tests/inertia/RemoveTeamMemberTest.php
diff --git a/stubs/tests/inertia/TwoFactorAuthenticationSettingsTest.php b/stubs/tests/inertia/TwoFactorAuthenticationSettingsTest.php
diff --git a/stubs/tests/inertia/UpdatePasswordTest.php b/stubs/tests/inertia/UpdatePasswordTest.php
diff --git a/stubs/tests/inertia/UpdateTeamMemberRoleTest.php b/stubs/tests/inertia/UpdateTeamMemberRoleTest.php
diff --git a/stubs/tests/inertia/UpdateTeamNameTest.php b/stubs/tests/inertia/UpdateTeamNameTest.php
diff --git a/stubs/tests/livewire/BrowserSessionsTest.php b/stubs/tests/livewire/BrowserSessionsTest.php
diff --git a/stubs/tests/livewire/DeleteTeamTest.php b/stubs/tests/livewire/DeleteTeamTest.php
diff --git a/stubs/tests/livewire/InviteTeamMemberTest.php b/stubs/tests/livewire/InviteTeamMemberTest.php
diff --git a/stubs/tests/livewire/LeaveTeamTest.php b/stubs/tests/livewire/LeaveTeamTest.php
diff --git a/stubs/tests/livewire/RemoveTeamMemberTest.php b/stubs/tests/livewire/RemoveTeamMemberTest.php
diff --git a/stubs/tests/livewire/UpdateTeamMemberRoleTest.php b/stubs/tests/livewire/UpdateTeamMemberRoleTest.php

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`$this->actingAs($user = User::factory()->create());`
`11`	`11`	`}`
`12`	`12`
`13`		`- $response = $this->post('/user/api-tokens', [`
	`13`	`+ $this->post('/user/api-tokens', [`
`14`	`14`	`'name' => 'Test Token',`
`15`	`15`	`'permissions' => [`
`16`	`16`	`'read',`