Skip to content

Conversation

@maru0914
Copy link
Contributor

@maru0914 maru0914 commented Feb 26, 2025

In the test workflow (tests.yml), SQLite file creation is included.
However, since phpunit.xml configures SQLite to run in memory during test execution, SQLite file is not needed in the test CI.

<env name="DB_CONNECTION" value="sqlite"/>
<env name="DB_DATABASE" value=":memory:"/>

I’ve also submitted same PRs for the Vue and React starter kits:
Vue: laravel/vue-starter-kit#56
React: laravel/react-starter-kit#52

Copy link
Contributor

@tnylea tnylea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@tnylea tnylea added the Approved Approved for Merge label Feb 26, 2025
@taylorotwell taylorotwell merged commit 3a9079e into laravel:main Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Approved for Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants