Improves PHP's Types Declarations (#16)

Signed-off-by: Mior Muhammad Zaki <[email protected]>

Author: crynobone

src/Console/BaseResourceCommand.php

@@ -21,6 +21,8 @@ class BaseResourceCommand extends Command
     protected function configure()
     {
         $this->addGeneratorPresetOptions();
+
+        parent::configure();
     }
 
     /** {@inheritDoc} */

src/Console/DashboardCommand.php

@@ -21,6 +21,8 @@ class DashboardCommand extends Command
     protected function configure()
     {
         $this->addGeneratorPresetOptions();
+
+        parent::configure();
     }
 
     /** {@inheritDoc} */

src/Console/FilterCommand.php

@@ -21,6 +21,8 @@ class FilterCommand extends Command
     protected function configure()
     {
         $this->addGeneratorPresetOptions();
+
+        parent::configure();
     }
 
     /** {@inheritDoc} */

src/Console/LensCommand.php

@@ -21,6 +21,8 @@ class LensCommand extends Command
     protected function configure()
     {
         $this->addGeneratorPresetOptions();
+
+        parent::configure();
     }
 
     /** {@inheritDoc} */

src/Console/PolicyMakeCommand.php

@@ -21,6 +21,8 @@ class PolicyMakeCommand extends Command
     protected function configure()
     {
         $this->addGeneratorPresetOptions();
+
+        parent::configure();
     }
 
     /** {@inheritDoc} */

src/Console/ResourceCommand.php

@@ -21,6 +21,8 @@ class ResourceCommand extends Command
     protected function configure()
     {
         $this->addGeneratorPresetOptions();
+
+        parent::configure();
     }
 
     /** {@inheritDoc} */

src/DevTool.php

@@ -44,10 +44,8 @@ public static function resourcesIn(string $directory): void
 
     /**
      * Register all of the resource classes within Workbench.
-     *
-     * @return void
      */
-    public static function resourcesInWorkbench()
+    public static function resourcesInWorkbench(): void
     {
         static::resourcesIn(Workbench::path(['app', 'Nova']));
     }

src/DevToolServiceProvider.php

@@ -21,10 +21,8 @@ class DevToolServiceProvider extends ServiceProvider
 {
     /**
      * Register services.
-     *
-     * @return void
      */
-    public function register()
+    public function register(): void
     {
         if (! $this->app->runningInConsole()) {
             return;
@@ -60,10 +58,8 @@ public function register()
 
     /**
      * Register the `nova:action` command.
-     *
-     * @return void
      */
-    protected function registerActionCommand()
+    protected function registerActionCommand(): void
     {
         $this->app->singleton(ActionCommand::class, function ($app) {
             return new Console\ActionCommand($app['files']);
@@ -72,10 +68,8 @@ protected function registerActionCommand()
 
     /**
      * Register the `nova:dashboard` command.
-     *
-     * @return void
      */
-    protected function registerDashboardCommand()
+    protected function registerDashboardCommand(): void
     {
         $this->app->singleton(DashboardCommand::class, function ($app) {
             return new Console\DashboardCommand($app['files']);
@@ -84,10 +78,8 @@ protected function registerDashboardCommand()
 
     /**
      * Register the `nova:base-resource` command.
-     *
-     * @return void
      */
-    protected function registerBaseResourceCommand()
+    protected function registerBaseResourceCommand(): void
     {
         $this->app->singleton(BaseResourceCommand::class, function ($app) {
             return new Console\BaseResourceCommand($app['files']);
@@ -96,10 +88,8 @@ protected function registerBaseResourceCommand()
 
     /**
      * Register the `nova:filter` command.
-     *
-     * @return void
      */
-    protected function registerFilterCommand()
+    protected function registerFilterCommand(): void
     {
         $this->app->singleton(FilterCommand::class, function ($app) {
             return new Console\FilterCommand($app['files']);
@@ -108,10 +98,8 @@ protected function registerFilterCommand()
 
     /**
      * Register the `nova:lens` command.
-     *
-     * @return void
      */
-    protected function registerLensCommand()
+    protected function registerLensCommand(): void
     {
         $this->app->singleton(LensCommand::class, function ($app) {
             return new Console\LensCommand($app['files']);
@@ -120,10 +108,8 @@ protected function registerLensCommand()
 
     /**
      * Register the `nova:policy` command.
-     *
-     * @return void
      */
-    protected function registerPolicyMakeCommand()
+    protected function registerPolicyMakeCommand(): void
     {
         $this->app->singleton(PolicyMakeCommand::class, function ($app) {
             return new Console\PolicyMakeCommand($app['files']);
@@ -132,10 +118,8 @@ protected function registerPolicyMakeCommand()
 
     /**
      * Register the `nova:resource` command.
-     *
-     * @return void
      */
-    protected function registerResourceCommand()
+    protected function registerResourceCommand(): void
     {
         $this->app->singleton(ResourceCommand::class, function ($app) {
             return new Console\ResourceCommand($app['files']);
@@ -144,10 +128,8 @@ protected function registerResourceCommand()
 
     /**
      * Bootstrap services.
-     *
-     * @return void
      */
-    public function boot()
+    public function boot(): void
     {
         if ($this->app->runningInConsole() && defined('TESTBENCH_CORE')) {
             tap($this->app->make('events'), function (EventDispatcher $event) {

src/Listeners/InstalledWorkbench.php

@@ -24,10 +24,8 @@ public function __construct(public Filesystem $files)
 
     /**
      * Handle the event.
-     *
-     * @return void
      */
-    public function handle(InstallEnded $event)
+    public function handle(InstallEnded $event): void
     {
         $force = false;
 

src/Listeners/InstallingWorkbench.php

@@ -18,10 +18,8 @@ public function __construct(public Filesystem $files)
 
     /**
      * Handle the event.
-     *
-     * @return void
      */
-    public function handle(InstallStarted $event)
+    public function handle(InstallStarted $event): void
     {
         if ($event->isBasicInstallation()) {
             throw new RuntimeException('Nova Devtool does not support installation with --basic` option');