Skip to content

Commit 6cb1f30

Browse files
authored
Fixed host argument to use the getHost() function (#957)
* fix-host-option: Fixed host argument to use the getHost() function from the inhirited trait. * fix-host-option: Added fix for the roadrunn er command as well.
1 parent bfac74c commit 6cb1f30

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Commands/StartFrankenPhpCommand.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class StartFrankenPhpCommand extends Command implements SignalableCommandInterfa
2828
{--host=127.0.0.1 : The IP address the server should bind to}
2929
{--port= : The port the server should be available on}
3030
{--admin-host=localhost : The host the admin server should be available on}
31-
{--admin-port= : The port the admin server should be available on}
31+
{--admin-port=2019 : The port the admin server should be available on}
3232
{--workers=auto : The number of workers that should be available to handle requests}
3333
{--max-requests=500 : The number of requests to process before reloading the server}
3434
{--caddyfile= : The path to the FrankenPHP Caddyfile file}
@@ -76,7 +76,7 @@ public function handle(ServerProcessInspector $inspector, ServerStateFile $serve
7676

7777
$this->forgetEnvironmentVariables();
7878

79-
$host = $this->option('host');
79+
$host = $this->getHost();
8080
$port = $this->getPort();
8181

8282
$https = $this->option('https');

src/Commands/StartRoadRunnerCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function handle(ServerProcessInspector $inspector, ServerStateFile $serve
8282
$roadRunnerBinary,
8383
'-c', $this->configPath(),
8484
'-o', 'version=3',
85-
'-o', 'http.address='.$this->option('host').':'.$this->getPort(),
85+
'-o', 'http.address='.$this->getHost().':'.$this->getPort(),
8686
'-o', 'server.command='.(new PhpExecutableFinder)->find().','.base_path(config('octane.roadrunner.command', 'vendor/bin/roadrunner-worker')),
8787
'-o', 'http.pool.num_workers='.$this->workerCount(),
8888
'-o', 'http.pool.max_jobs='.$this->option('max-requests'),

0 commit comments

Comments
 (0)