Skip to content

Commit 6dbb1d8

Browse files
authored
Fix swoole host only configurable via --host parameter + incorrect default port (#762)
* remove default values for --host * fix incorrect default port
1 parent fc4cb9a commit 6dbb1d8

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

bin/createSwooleServer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
$server = new Swoole\Http\Server(
1111
$host,
12-
$serverState['port'] ?? 8080,
12+
$serverState['port'] ?? 8000,
1313
$config['swoole']['mode'] ?? SWOOLE_PROCESS,
1414
($config['swoole']['ssl'] ?? false)
1515
? $sock | SWOOLE_SSL

src/Commands/StartCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class StartCommand extends Command implements SignalableCommandInterface
1515
*/
1616
public $signature = 'octane:start
1717
{--server= : The server that should be used to serve the application}
18-
{--host=127.0.0.1 : The IP address the server should bind to}
18+
{--host= : The IP address the server should bind to}
1919
{--port= : The port the server should be available on [default: "8000"]}
2020
{--rpc-host= : The RPC IP address the server should bind to}
2121
{--rpc-port= : The RPC port the server should be available on}

src/Commands/StartRoadRunnerCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class StartRoadRunnerCommand extends Command implements SignalableCommandInterfa
2222
* @var string
2323
*/
2424
public $signature = 'octane:roadrunner
25-
{--host=127.0.0.1 : The IP address the server should bind to}
25+
{--host= : The IP address the server should bind to}
2626
{--port= : The port the server should be available on}
2727
{--rpc-host= : The RPC IP address the server should bind to}
2828
{--rpc-port= : The RPC port the server should be available on}

src/Commands/StartSwooleCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class StartSwooleCommand extends Command implements SignalableCommandInterface
2020
* @var string
2121
*/
2222
public $signature = 'octane:swoole
23-
{--host=127.0.0.1 : The IP address the server should bind to}
23+
{--host= : The IP address the server should bind to}
2424
{--port= : The port the server should be available on}
2525
{--workers=auto : The number of workers that should be available to handle requests}
2626
{--task-workers=auto : The number of task workers that should be available to handle tasks}

0 commit comments

Comments
 (0)