Merge branch 'handle-invalid-server'

Author: taylorotwell

src/Commands/ReloadCommand.php

@@ -30,9 +30,11 @@ public function handle()
     {
         $server = $this->option('server') ?: config('octane.server');
 
-        return $server == 'swoole'
-            ? $this->reloadSwooleServer()
-            : $this->reloadRoadRunnerServer();
+        return match ($server) {
+            'swoole' => $this->reloadSwooleServer(),
+            'roadrunner' => $this->reloadRoadRunnerServer(),
+            default => $this->invalidServer($server),
+        };
     }
 
     /**
@@ -78,4 +80,17 @@ protected function reloadRoadRunnerServer()
 
         return 0;
     }
+
+    /**
+     * Inform the user that the server type is invalid.
+     *
+     * @param  string  $server
+     * @return int
+     */
+    protected function invalidServer(string $server)
+    {
+        $this->error("Invalid server: {$server}.");
+
+        return 1;
+    }
 }

src/Commands/StartCommand.php

@@ -45,9 +45,11 @@ public function handle()
 
         $server = $this->option('server') ?: config('octane.server');
 
-        return $server == 'swoole'
-            ? $this->startSwooleServer()
-            : $this->startRoadRunnerServer();
+        return match ($server) {
+            'swoole' => $this->startSwooleServer(),
+            'roadrunner' => $this->startRoadRunnerServer(),
+            default => $this->invalidServer($server),
+        };
     }
 
     /**
@@ -82,4 +84,17 @@ protected function startRoadRunnerServer()
             '--watch' => $this->option('watch'),
         ]);
     }
+
+    /**
+     * Inform the user that the server type is invalid.
+     *
+     * @param  string  $server
+     * @return int
+     */
+    protected function invalidServer(string $server)
+    {
+        $this->error("Invalid server: {$server}.");
+
+        return 1;
+    }
 }

src/Commands/StopCommand.php

@@ -32,9 +32,11 @@ public function handle()
     {
         $server = $this->option('server') ?: config('octane.server');
 
-        return $server == 'swoole'
-            ? $this->stopSwooleServer()
-            : $this->stopRoadRunnerServer();
+        return match ($server) {
+            'swoole' => $this->stopSwooleServer(),
+            'roadrunner' => $this->stopRoadRunnerServer(),
+            default => $this->invalidServer($server),
+        };
     }
 
     /**
@@ -88,4 +90,17 @@ protected function stopRoadRunnerServer()
 
         return 0;
     }
+
+    /**
+     * Inform the user that the server type is invalid.
+     *
+     * @param  string  $server
+     * @return int
+     */
+    protected function invalidServer(string $server)
+    {
+        $this->error("Invalid server: {$server}.");
+
+        return 1;
+    }
 }