Skip to content

Commit fc0a649

Browse files
authored
Merge pull request #743 from laravel/feat/herd-support
[2.x] Adds Herd support
2 parents 75f8d9d + 54fd740 commit fc0a649

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

src/Commands/Concerns/InstallsRoadRunnerDependencies.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ trait InstallsRoadRunnerDependencies
2121
*
2222
* @var string
2323
*/
24-
protected $requiredVersion = '2023.1.1';
24+
protected $requiredVersion = '2023.3.0';
2525

2626
/**
2727
* Determine if RoadRunner is installed.

src/Commands/Concerns/InteractsWithIO.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ trait InteractsWithIO
2222
*/
2323
protected $ignoreMessages = [
2424
'destroy signal received',
25+
'req-resp mode',
2526
'scan command',
2627
'sending stop request to the worker',
2728
'stop signal received, grace timeout is: ',
@@ -32,6 +33,7 @@ trait InteractsWithIO
3233
'worker destructed',
3334
'worker destroyed',
3435
'[INFO] RoadRunner server started; version:',
36+
'[INFO] sdnotify: not notified',
3537
];
3638

3739
/**

src/Commands/StartRoadRunnerCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public function handle(ServerProcessInspector $inspector, ServerStateFile $serve
7979
'-c', $this->configPath(),
8080
'-o', 'version=3',
8181
'-o', 'http.address='.$this->option('host').':'.$this->getPort(),
82-
'-o', 'server.command='.(new PhpExecutableFinder)->find().' '.base_path(config('octane.roadrunner.command', 'vendor/bin/roadrunner-worker')),
82+
'-o', 'server.command='.(new PhpExecutableFinder)->find().','.base_path(config('octane.roadrunner.command', 'vendor/bin/roadrunner-worker')),
8383
'-o', 'http.pool.num_workers='.$this->workerCount(),
8484
'-o', 'http.pool.max_jobs='.$this->option('max-requests'),
8585
'-o', 'rpc.listen=tcp://'.$this->rpcHost().':'.$this->rpcPort(),

0 commit comments

Comments
 (0)