Fix - Correct retrieval of 0 feature values via DB driver (#143)

Author: pocketninja

src/Drivers/DatabaseDriver.php

@@ -158,7 +158,7 @@ public function getAll($features): array
             $filtered = $records->where('name', $feature)->where('scope', Feature::serializeScope($scope));
 
             if ($filtered->isNotEmpty()) {
-                return json_decode($filtered->value('value'), flags: JSON_OBJECT_AS_ARRAY | JSON_THROW_ON_ERROR); // @phpstan-ignore argument.type
+                return json_decode($filtered->first()->value, flags: JSON_OBJECT_AS_ARRAY | JSON_THROW_ON_ERROR);
             }
 
             return with($this->resolveValue($feature, $scope), function ($value) use ($feature, $scope, $inserts) {

tests/Feature/ArrayDriverTest.php

@@ -1178,6 +1178,41 @@ public function test_it_can_resolve_feature_instance()
         $this->assertInstanceOf(Lottery::class, $feature);
         $this->assertSame('345', $feature());
     }
+
+    public function test_can_retrieve_scalar_values_without_in_memory_cache(): void
+    {
+        $data = [
+            'one' => 1,
+            'ten' => 10,
+            'zero' => 0,
+            'minus-one' => -1,
+            'minus-ten' => -10,
+            'one-point-five' => 1.5,
+            'ten-point-five' => 10.5,
+            'zero-point-five' => 0.5,
+            'minus-one-point-five' => -1.5,
+            'minus-ten-point-five' => -10.5,
+            'bool-true' => true,
+            'bool-false' => false,
+            'null' => null,
+        ];
+
+        $user = new User;
+
+        foreach ($data as $name => $expectedValue) {
+            $feature = 'scalar-feature:'.$name;
+            Feature::define($feature, fn(User $user) => $expectedValue);
+
+            $generated = Feature::for($user)->value($feature);
+
+            Feature::flushCache();
+
+            $retrieved = Feature::for($user)->value($feature);
+
+            $this->assertEquals($expectedValue, $generated);
+            $this->assertEquals($expectedValue, $retrieved);
+        }
+    }
 }
 
 class MyFeature

tests/Feature/DatabaseDriverTest.php

@@ -1708,6 +1708,41 @@ public function test_can_retrieve_all_features_for_differing_scope_types(): void
         $this->assertCount(8, DB::getQueryLog());
         $this->assertCount(13, DB::table('features')->get());
     }
+
+    public function test_can_retrieve_scalar_values_without_in_memory_cache(): void
+    {
+        $data = [
+            'one' => 1,
+            'ten' => 10,
+            'zero' => 0,
+            'minus-one' => -1,
+            'minus-ten' => -10,
+            'one-point-five' => 1.5,
+            'ten-point-five' => 10.5,
+            'zero-point-five' => 0.5,
+            'minus-one-point-five' => -1.5,
+            'minus-ten-point-five' => -10.5,
+            'bool-true' => true,
+            'bool-false' => false,
+            'null' => null,
+        ];
+
+        $user = new User;
+
+        foreach ($data as $name => $expectedValue) {
+            $feature = 'scalar-feature:'.$name;
+            Feature::define($feature, fn(User $user) => $expectedValue);
+
+            $generated = Feature::for($user)->value($feature);
+
+            Feature::flushCache();
+
+            $retrieved = Feature::for($user)->value($feature);
+
+            $this->assertEquals($expectedValue, $generated);
+            $this->assertEquals($expectedValue, $retrieved);
+        }
+    }
 }
 
 class UnregisteredFeature