adding some updates based on Joe feedback

tnylea · tnylea · commit 427e966fcdff · 2025-01-05T11:48:43.000-05:00
diff --git a/resources/js/components/app-sidebar.tsx b/resources/js/components/app-sidebar.tsx
@@ -35,7 +35,7 @@ const footerNavItems: NavItem[] = [
 
 export function AppSidebar() {
     return (
-        <Sidebar variant="sidebar" collapsible="icon">
+        <Sidebar collapsible="icon">
             <SidebarHeader>
                 <SidebarMenu>
                     <SidebarMenuItem>
diff --git a/resources/js/components/settings/heading.tsx b/resources/js/components/settings/heading.tsx
@@ -9,7 +9,7 @@ export default function Heading({ title, description }: HeadingProps) {
     return (
         <div>
             <header>
-                <h3 className="text-lg font-medium">{title}</h3>
+                <h3 className="text-lg font-medium mb-1">{title}</h3>
                 {description && (
                     <p className="text-sm text-muted-foreground">
                         {description}
diff --git a/resources/js/layouts/app-layout.tsx b/resources/js/layouts/app-layout.tsx
@@ -22,17 +22,17 @@ interface BreadcrumbItemType {
 
 interface AppLayoutProps {
     children: React.ReactNode
-    breadcrumbItems?: BreadcrumbItemType[]
+    breadcrumbs?: BreadcrumbItemType[]
 }
 
 export default function App({ 
     children,
-    breadcrumbItems = [],
+    breadcrumbs = [],
 }: AppLayoutProps) {
 
     const [isOpen, setIsOpen] = useState(() => 
         typeof window !== 'undefined' ? 
-            localStorage.getItem('sidebar') === 'true' : 
+            localStorage.getItem('sidebar') !== 'false' : 
             true
     );
 
@@ -54,13 +54,13 @@ export default function App({
                 <header className="flex h-16 shrink-0 items-center w-full justify-between gap-2 border-b px-4">
                     <div className="flex items-center gap-2">
                         <SidebarTrigger className="-ml-1" />
-                        {breadcrumbItems.length > 0 && (
+                        {breadcrumbs.length > 0 && (
                             <>
                                 <Separator orientation="vertical" className="mr-2 h-4" />
                                 <Breadcrumb>
                                     <BreadcrumbList>
-                                        {breadcrumbItems.map((item, index) => {
-                                            const isLast = index === breadcrumbItems.length - 1;
+                                        {breadcrumbs.map((item, index) => {
+                                            const isLast = index === breadcrumbs.length - 1;
 
                                             return (
                                                 <Fragment key={index}>
diff --git a/resources/js/pages/auth/login.tsx b/resources/js/pages/auth/login.tsx
@@ -65,6 +65,7 @@ export default function Login({
                             type="email"
                             required
                             autoFocus
+                            tabIndex={1}
                             value={data.email}
                             onChange={(e) => setData("email", e.target.value)}
                         />
@@ -78,6 +79,7 @@ export default function Login({
                                 <Link
                                     href={route("password.request")}
                                     className="ml-auto text-sm underline-offset-4 hover:underline"
+                                    tabIndex={5}
                                 >
                                     Forgot your password?
                                 </Link>
@@ -87,6 +89,7 @@ export default function Login({
                             id="password"
                             type="password"
                             required
+                            tabIndex={2}
                             value={data.password}
                             onChange={(e) => setData("password", e.target.value)}
                         />
@@ -96,6 +99,7 @@ export default function Login({
                     <Button 
                         type="submit" 
                         className="w-full" 
+                        tabIndex={3}
                         disabled={processing}
                     >
                         {processing && (
@@ -112,6 +116,7 @@ export default function Login({
                     <Link 
                         href={route("register")} 
                         className="underline underline-offset-4"
+                        tabIndex={4}
                     >
                         Sign up
                     </Link>
diff --git a/resources/js/pages/auth/register.tsx b/resources/js/pages/auth/register.tsx
@@ -52,6 +52,7 @@ export default function Register() {
                             type="text"
                             required
                             autoFocus
+                            tabIndex={1}
                             value={data.name}
                             onChange={(e) => setData("name", e.target.value)}
                             disabled={processing}
@@ -65,6 +66,7 @@ export default function Register() {
                             id="email"
                             type="email"
                             required
+                            tabIndex={2}
                             value={data.email}
                             onChange={(e) => setData("email", e.target.value)}
                             disabled={processing}
@@ -78,6 +80,7 @@ export default function Register() {
                             id="password"
                             type="password"
                             required
+                            tabIndex={3}
                             value={data.password}
                             onChange={(e) => setData("password", e.target.value)}
                             disabled={processing}
@@ -93,6 +96,7 @@ export default function Register() {
                             id="password_confirmation"
                             type="password"
                             required
+                            tabIndex={4}
                             value={data.password_confirmation}
                             onChange={(e) => setData("password_confirmation", e.target.value)}
                             disabled={processing}
@@ -103,6 +107,7 @@ export default function Register() {
                     <Button 
                         type="submit" 
                         className="w-full" 
+                        tabIndex={5}
                         disabled={processing}
                     >
                         {processing && (
@@ -119,6 +124,7 @@ export default function Register() {
                     <Link 
                         href={route("login")} 
                         className="underline underline-offset-4"
+                        tabIndex={6}
                     >
                         Log in
                     </Link>
diff --git a/resources/js/pages/dashboard.tsx b/resources/js/pages/dashboard.tsx
@@ -6,7 +6,7 @@ interface BreadcrumbItem {
     href: string
 }
 
-const breadcrumbItems: BreadcrumbItem[] = [
+const breadcrumbs: BreadcrumbItem[] = [
     {
         title: 'Dashboard',
         href: '/dashboard'
@@ -15,7 +15,7 @@ const breadcrumbItems: BreadcrumbItem[] = [
 
 export default function Dashboard() {
     return (
-        <AppLayout breadcrumbItems={breadcrumbItems}>
+        <AppLayout breadcrumbs={breadcrumbs}>
             <Head title="Dashboard" />
             <div className="flex flex-1 flex-col gap-4 p-4">
                 <div className="grid auto-rows-min gap-4 md:grid-cols-3">
diff --git a/resources/js/pages/settings/appearance.tsx b/resources/js/pages/settings/appearance.tsx
@@ -13,7 +13,7 @@ interface BreadcrumbItem {
     href: string
 }
 
-const breadcrumbItems: BreadcrumbItem[] = [
+const breadcrumbs: BreadcrumbItem[] = [
     {
         title: 'Appearance Settings',
         href: '/settings/appearance'
@@ -24,7 +24,7 @@ export default function Appearance() {
 
     return (
         <AppLayout
-            breadcrumbItems={breadcrumbItems}
+            breadcrumbs={breadcrumbs}
         >
             <Head title="Appearance Settings" />
 
diff --git a/resources/js/pages/settings/password.tsx b/resources/js/pages/settings/password.tsx
@@ -10,7 +10,7 @@ import { Input } from "@/components/ui/input";
 import { Label } from "@/components/ui/label";
 import SettingsHeading from "@/components/settings/heading";
 
-const breadcrumbItems = [
+const breadcrumbs = [
     {
         title: 'Password Settings',
         href: '/settings/password'
@@ -63,7 +63,7 @@ export default function Password({
 
     return (
         <AppLayout
-            breadcrumbItems={breadcrumbItems}
+            breadcrumbs={breadcrumbs}
         >
             <Head title="Profile Settings" />
 
diff --git a/resources/js/pages/settings/profile.tsx b/resources/js/pages/settings/profile.tsx
@@ -19,7 +19,7 @@ interface BreadcrumbItem {
     href: string
 }
 
-const breadcrumbItems: BreadcrumbItem[] = [
+const breadcrumbs: BreadcrumbItem[] = [
     {
         title: 'Profile Settings',
         href: '/settings/profile'
@@ -52,7 +52,7 @@ export default function Profile({
 
     return (
         <AppLayout
-            breadcrumbItems={breadcrumbItems}
+            breadcrumbs={breadcrumbs}
         >
             <Head title="Profile Settings" />
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ interface BreadcrumbItem {`
`13`	`13`	`href: string`
`14`	`14`	`}`
`15`	`15`
`16`		`-const breadcrumbItems: BreadcrumbItem[] = [`
	`16`	`+const breadcrumbs: BreadcrumbItem[] = [`
`17`	`17`	`{`
`18`	`18`	`title: 'Appearance Settings',`
`19`	`19`	`href: '/settings/appearance'`
`@@ -24,7 +24,7 @@ export default function Appearance() {`
`24`	`24`
`25`	`25`	`return (`
`26`	`26`	`<AppLayout`
`27`		`- breadcrumbItems={breadcrumbItems}`
	`27`	`+ breadcrumbs={breadcrumbs}`
`28`	`28`	`>`
`29`	`29`	`<Head title="Appearance Settings" />`
`30`	`30`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ import { Input } from "@/components/ui/input";`
`10`	`10`	`import { Label } from "@/components/ui/label";`
`11`	`11`	`import SettingsHeading from "@/components/settings/heading";`
`12`	`12`
`13`		`-const breadcrumbItems = [`
	`13`	`+const breadcrumbs = [`
`14`	`14`	`{`
`15`	`15`	`title: 'Password Settings',`
`16`	`16`	`href: '/settings/password'`
`@@ -63,7 +63,7 @@ export default function Password({`
`63`	`63`
`64`	`64`	`return (`
`65`	`65`	`<AppLayout`
`66`		`- breadcrumbItems={breadcrumbItems}`
	`66`	`+ breadcrumbs={breadcrumbs}`
`67`	`67`	`>`
`68`	`68`	`<Head title="Profile Settings" />`
`69`	`69`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ interface BreadcrumbItem {`
`19`	`19`	`href: string`
`20`	`20`	`}`
`21`	`21`
`22`		`-const breadcrumbItems: BreadcrumbItem[] = [`
	`22`	`+const breadcrumbs: BreadcrumbItem[] = [`
`23`	`23`	`{`
`24`	`24`	`title: 'Profile Settings',`
`25`	`25`	`href: '/settings/profile'`
`@@ -52,7 +52,7 @@ export default function Profile({`
`52`	`52`
`53`	`53`	`return (`
`54`	`54`	`<AppLayout`
`55`		`- breadcrumbItems={breadcrumbItems}`
	`55`	`+ breadcrumbs={breadcrumbs}`
`56`	`56`	`>`
`57`	`57`	`<Head title="Profile Settings" />`
`58`	`58`