Skip to content

Commit 47fb6fc

Browse files
authored
Update app-header.tsx
Fixed active element mark on the navigation bar. replaced the div element (which were outside and nav ling) by border
1 parent 1936a8d commit 47fb6fc

File tree

1 file changed

+25
-23
lines changed

1 file changed

+25
-23
lines changed

resources/js/components/app-header.tsx

Lines changed: 25 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -161,30 +161,32 @@ export function AppHeader({ breadcrumbs = [] }: AppHeaderProps) {
161161
key={index}
162162
className="relative flex h-full items-center"
163163
>
164-
<Link
165-
href={item.href}
166-
className={cn(
167-
navigationMenuTriggerStyle(),
168-
page.url ===
169-
(typeof item.href ===
170-
'string'
171-
? item.href
172-
: item.href.url) &&
173-
activeItemStyles,
174-
'h-9 cursor-pointer px-3',
175-
)}
164+
<div className={
165+
page.url === item.href.url && ("h-full flex items-center border-b border-black dark:border-white")
166+
}
176167
>
177-
{item.icon && (
178-
<Icon
179-
iconNode={item.icon}
180-
className="mr-2 h-4 w-4"
181-
/>
182-
)}
183-
{item.title}
184-
</Link>
185-
{page.url === item.href && (
186-
<div className="absolute bottom-0 left-0 h-0.5 w-full translate-y-px bg-black dark:bg-white"></div>
187-
)}
168+
<Link
169+
href={item.href}
170+
className={cn(
171+
navigationMenuTriggerStyle(),
172+
page.url ===
173+
(typeof item.href ===
174+
'string'
175+
? item.href
176+
: item.href.url) &&
177+
activeItemStyles,
178+
'h-9 cursor-pointer px-3',
179+
)}
180+
>
181+
{item.icon && (
182+
<Icon
183+
iconNode={item.icon}
184+
className="mr-2 h-4 w-4"
185+
/>
186+
)}
187+
{item.title}
188+
</Link>
189+
</div>
188190
</NavigationMenuItem>
189191
))}
190192
</NavigationMenuList>

0 commit comments

Comments
 (0)