Skip to content

Commit adfa299

Browse files
BennettPhilBennettPhil
committed
test(upload): adding upload tests
1 parent 1af21af commit adfa299

File tree

8 files changed

+372
-12
lines changed

8 files changed

+372
-12
lines changed

‎app/Http/Controllers/FileUploadController.php‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,10 @@ public function store(Request $request)
3838

3939
$file = $request->file('file');
4040
$originalFilename = $file->getClientOriginalName();
41-
$filename = Str::uuid() . '.' . $file->getClientOriginalExtension();
41+
$filename = Str::uuid().'.'.$file->getClientOriginalExtension();
4242

4343
// Ensure the uploads directory exists
44-
if (!Storage::exists('uploads')) {
44+
if (! Storage::exists('uploads')) {
4545
Storage::makeDirectory('uploads');
4646
Log::info('Created uploads directory on default disk');
4747
}
@@ -57,7 +57,7 @@ public function store(Request $request)
5757
'full_path' => Storage::path($path),
5858
'exists' => Storage::exists($path) ? 'Yes' : 'No',
5959
'default_disk' => config('filesystems.default'),
60-
'disk_root' => config('filesystems.disks.' . config('filesystems.default') . '.root'),
60+
'disk_root' => config('filesystems.disks.'.config('filesystems.default').'.root'),
6161
]);
6262

6363
// Create a new file upload record
@@ -99,13 +99,13 @@ public function download(FileUpload $fileUpload)
9999
]);
100100

101101
// Check if the file exists
102-
if (!Storage::exists($fileUpload->path)) {
102+
if (! Storage::exists($fileUpload->path)) {
103103
// Try to check where the file might be
104104
$alternativePaths = [
105-
'uploads/' . $fileUpload->filename,
106-
'private/uploads/' . $fileUpload->filename,
107-
'app/uploads/' . $fileUpload->filename,
108-
'app/private/uploads/' . $fileUpload->filename,
105+
'uploads/'.$fileUpload->filename,
106+
'private/uploads/'.$fileUpload->filename,
107+
'app/uploads/'.$fileUpload->filename,
108+
'app/private/uploads/'.$fileUpload->filename,
109109
];
110110

111111
$foundAlternative = false;
@@ -119,7 +119,7 @@ public function download(FileUpload $fileUpload)
119119
}
120120
}
121121

122-
if (!$foundAlternative) {
122+
if (! $foundAlternative) {
123123
Log::error('File not found for download', [
124124
'file_id' => $fileUpload->id,
125125
'path' => $fileUpload->path,

‎app/Models/FileUpload.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
use Illuminate\Database\Eloquent\Factories\HasFactory;
66
use Illuminate\Database\Eloquent\Model;
77
use Illuminate\Database\Eloquent\Relations\BelongsTo;
8-
use Illuminate\Support\Facades\Log;
98

109
class FileUpload extends Model
1110
{

‎database/factories/FileUploadFactory.php‎

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
<?php
2+
3+
namespace Database\Factories;
4+
5+
use App\Models\User;
6+
use Illuminate\Database\Eloquent\Factories\Factory;
7+
use Illuminate\Support\Str;
8+
9+
/**
10+
* @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\FileUpload>
11+
*/
12+
class FileUploadFactory extends Factory
13+
{
14+
/**
15+
* Define the model's default state.
16+
*
17+
* @return array<string, mixed>
18+
*/
19+
public function definition(): array
20+
{
21+
$filename = Str::uuid() . '.pdf';
22+
23+
return [
24+
'user_id' => User::factory(),
25+
'filename' => $filename,
26+
'original_filename' => $this->faker->word() . '.pdf',
27+
'path' => 'uploads/' . $filename,
28+
'mime_type' => 'application/pdf',
29+
'size' => $this->faker->numberBetween(1000, 5000000),
30+
'status' => $this->faker->randomElement(['uploaded', 'processing', 'processed']),
31+
];
32+
}
33+
34+
/**
35+
* Indicate that the file is processed.
36+
*/
37+
public function processed(): self
38+
{
39+
return $this->state(function (array $attributes) {
40+
return [
41+
'status' => 'processed',
42+
];
43+
});
44+
}
45+
46+
/**
47+
* Indicate that the file is processing.
48+
*/
49+
public function processing(): self
50+
{
51+
return $this->state(function (array $attributes) {
52+
return [
53+
'status' => 'processing',
54+
];
55+
});
56+
}
57+
}

‎resources/js/components/content-header.tsx‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,10 @@ export function ContentHeader() {
6868
</div>
6969
<div className="mt-5 flex lg:mt-0 lg:ml-4">
7070
<span className="sm:ml-3">
71-
<Button onClick={() => setIsModalOpen(true)}>
71+
<Button
72+
onClick={() => setIsModalOpen(true)}
73+
data-testid="upload-button"
74+
>
7275
<ArrowUpCircleIcon className="mr-1.5 -ml-0.5 size-5" />
7376
Upload
7477
</Button>
@@ -146,12 +149,14 @@ export function ContentHeader() {
146149
type="button"
147150
onClick={() => setIsModalOpen(false)}
148151
color="white"
152+
data-testid="cancel-upload-button"
149153
>
150154
Cancel
151155
</Button>
152156
<Button
153157
type="submit"
154158
disabled={processing || !data.file}
159+
data-testid="upload-submit-button"
155160
>
156161
Upload
157162
</Button>

‎resources/js/components/content-list.tsx‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,11 @@ export function ContentList() {
235235
<Button outline onClick={() => setShowDeleteAlert(false)}>
236236
Cancel
237237
</Button>
238-
<Button color="red" onClick={handleDelete}>
238+
<Button
239+
color="red"
240+
onClick={handleDelete}
241+
data-testid="confirm-delete-button"
242+
>
239243
Delete
240244
</Button>
241245
</AlertActions>

‎tests/Browser/test-files/document.pdf‎

Whitespace-only changes.

‎tests/Feature/FileUploadFeatureTest.php‎

Lines changed: 240 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,240 @@
1+
<?php
2+
3+
namespace Tests\Feature;
4+
5+
use App\Models\FileUpload;
6+
use App\Models\User;
7+
use Illuminate\Foundation\Testing\RefreshDatabase;
8+
use Illuminate\Foundation\Testing\WithFaker;
9+
use Illuminate\Http\UploadedFile;
10+
use Illuminate\Support\Facades\Storage;
11+
use Tests\TestCase;
12+
13+
class FileUploadFeatureTest extends TestCase
14+
{
15+
use RefreshDatabase;
16+
17+
protected function setUp(): void
18+
{
19+
parent::setUp();
20+
Storage::fake('local');
21+
}
22+
23+
/** @test */
24+
public function unauthenticated_users_cannot_access_file_routes()
25+
{
26+
// Try to access file upload page
27+
$this->get(route('content.index'))->assertRedirect('/login');
28+
29+
// Try to upload a file
30+
$this->post(route('content.upload'), [
31+
'file' => UploadedFile::fake()->create('document.pdf', 100),
32+
])->assertRedirect('/login');
33+
34+
// Try to download a file
35+
$fileUpload = FileUpload::factory()->create();
36+
$this->get(route('content.download', $fileUpload->id))->assertRedirect('/login');
37+
38+
// Try to delete a file
39+
$this->delete(route('content.destroy', $fileUpload->id))->assertRedirect('/login');
40+
}
41+
42+
/** @test */
43+
public function authenticated_user_can_upload_a_file()
44+
{
45+
$user = User::factory()->create();
46+
47+
$file = UploadedFile::fake()->create('document.pdf', 100);
48+
49+
$response = $this->actingAs($user)
50+
->post(route('content.upload'), [
51+
'file' => $file,
52+
]);
53+
54+
$response->assertRedirect(route('content.index'));
55+
$response->assertSessionHas('success');
56+
57+
// Assert database has record
58+
$this->assertDatabaseHas('file_uploads', [
59+
'user_id' => $user->id,
60+
'original_filename' => 'document.pdf',
61+
'mime_type' => 'application/pdf',
62+
]);
63+
64+
// Assert file exists in storage
65+
$fileUpload = FileUpload::first();
66+
$this->assertTrue(Storage::disk('local')->exists($fileUpload->path));
67+
}
68+
69+
/** @test */
70+
public function user_can_download_their_own_file()
71+
{
72+
$user = User::factory()->create();
73+
74+
// Create fake file and store it
75+
$file = UploadedFile::fake()->create('document.pdf', 100);
76+
$storedFile = Storage::putFileAs('uploads', $file, 'test-document.pdf');
77+
78+
// Create file upload record
79+
$fileUpload = FileUpload::factory()->create([
80+
'user_id' => $user->id,
81+
'filename' => 'test-document.pdf',
82+
'original_filename' => 'document.pdf',
83+
'path' => $storedFile,
84+
'mime_type' => 'application/pdf',
85+
]);
86+
87+
$response = $this->actingAs($user)
88+
->get(route('content.download', $fileUpload->id));
89+
90+
$response->assertStatus(200)
91+
->assertHeader('Content-Disposition', 'attachment; filename=document.pdf');
92+
}
93+
94+
/** @test */
95+
public function user_cannot_download_another_users_file()
96+
{
97+
$user1 = User::factory()->create();
98+
$user2 = User::factory()->create();
99+
100+
// Create file for user1
101+
$file = UploadedFile::fake()->create('document.pdf', 100);
102+
$storedFile = Storage::putFileAs('uploads', $file, 'test-document.pdf');
103+
104+
$fileUpload = FileUpload::factory()->create([
105+
'user_id' => $user1->id,
106+
'filename' => 'test-document.pdf',
107+
'original_filename' => 'document.pdf',
108+
'path' => $storedFile,
109+
'mime_type' => 'application/pdf',
110+
]);
111+
112+
// User2 attempts to download User1's file
113+
$response = $this->actingAs($user2)
114+
->get(route('content.download', $fileUpload->id));
115+
116+
$response->assertStatus(403);
117+
}
118+
119+
/** @test */
120+
public function user_can_delete_their_own_file()
121+
{
122+
$user = User::factory()->create();
123+
124+
// Create and store file
125+
$file = UploadedFile::fake()->create('document.pdf', 100);
126+
$storedFile = Storage::putFileAs('uploads', $file, 'test-document.pdf');
127+
128+
$fileUpload = FileUpload::factory()->create([
129+
'user_id' => $user->id,
130+
'filename' => 'test-document.pdf',
131+
'original_filename' => 'document.pdf',
132+
'path' => $storedFile,
133+
]);
134+
135+
$response = $this->actingAs($user)
136+
->delete(route('content.destroy', $fileUpload->id));
137+
138+
$response->assertRedirect();
139+
$response->assertSessionHas('success');
140+
141+
// Assert database record is deleted
142+
$this->assertDatabaseMissing('file_uploads', ['id' => $fileUpload->id]);
143+
144+
// Assert file is deleted from storage
145+
$this->assertFalse(Storage::exists($storedFile));
146+
}
147+
148+
/** @test */
149+
public function user_cannot_delete_another_users_file()
150+
{
151+
$user1 = User::factory()->create();
152+
$user2 = User::factory()->create();
153+
154+
// Create file for user1
155+
$file = UploadedFile::fake()->create('document.pdf', 100);
156+
$storedFile = Storage::putFileAs('uploads', $file, 'test-document.pdf');
157+
158+
$fileUpload = FileUpload::factory()->create([
159+
'user_id' => $user1->id,
160+
'filename' => 'test-document.pdf',
161+
'original_filename' => 'document.pdf',
162+
'path' => $storedFile,
163+
]);
164+
165+
// User2 attempts to delete User1's file
166+
$response = $this->actingAs($user2)
167+
->delete(route('content.destroy', $fileUpload->id));
168+
169+
$response->assertRedirect();
170+
$response->assertSessionHas('error');
171+
172+
// Assert database record still exists
173+
$this->assertDatabaseHas('file_uploads', ['id' => $fileUpload->id]);
174+
}
175+
176+
/** @test */
177+
public function it_validates_file_upload_requirements()
178+
{
179+
$user = User::factory()->create();
180+
181+
// Test without a file
182+
$response = $this->actingAs($user)
183+
->post(route('content.upload'), []);
184+
185+
$response->assertSessionHasErrors('file');
186+
187+
// Test with too large file
188+
$hugeFile = UploadedFile::fake()->create('huge.pdf', 250000); // 250MB
189+
190+
$response = $this->actingAs($user)
191+
->post(route('content.upload'), [
192+
'file' => $hugeFile,
193+
]);
194+
195+
$response->assertSessionHasErrors('file');
196+
}
197+
198+
/** @test */
199+
public function it_handles_missing_files_gracefully()
200+
{
201+
$user = User::factory()->create();
202+
203+
// Create file record but don't actually store the file
204+
$fileUpload = FileUpload::factory()->create([
205+
'user_id' => $user->id,
206+
'path' => 'uploads/nonexistent-file.pdf',
207+
]);
208+
209+
$response = $this->actingAs($user)
210+
->get(route('content.download', $fileUpload->id));
211+
212+
$response->assertStatus(404);
213+
}
214+
215+
/** @test */
216+
public function it_updates_file_status_correctly()
217+
{
218+
$user = User::factory()->create();
219+
220+
// Create fake file and store it
221+
$file = UploadedFile::fake()->create('document.pdf', 100);
222+
$storedFile = Storage::putFileAs('uploads', $file, 'test-document.pdf');
223+
224+
$fileUpload = FileUpload::factory()->create([
225+
'user_id' => $user->id,
226+
'filename' => 'test-document.pdf',
227+
'original_filename' => 'document.pdf',
228+
'path' => $storedFile,
229+
'status' => 'uploaded',
230+
]);
231+
232+
$response = $this->actingAs($user)
233+
->patch(route('content.update-status', $fileUpload->id), [
234+
'status' => 'processing',
235+
]);
236+
237+
$response->assertRedirect();
238+
$this->assertEquals('processing', $fileUpload->fresh()->status);
239+
}
240+
}

0 commit comments

Comments
 (0)