"weird" hamburger menu with header layout on mobile view #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnylea
approved these changes
Feb 28, 2025
Contributor
tnylea
left a comment
tnylea
left a comment
There was a problem hiding this comment.
Thanks for the before and after.
You're right. This happened after we updated the ShadCN components to the latest. Appreciate the fix.
JoeyMckenzie
pushed a commit
to JoeyMckenzie/laravel-official-react-starter-kit
that referenced
this pull request
Mar 2, 2025
lucianodigital2b
referenced
this pull request
in lucianodigital2b/clevernote
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bit of an unsightly look to the header layout when the hamburger menu is opened on a mobile device, simply need more padding. In this PR, I added padding for the hamburger menu. Maybe this is still for other starter kits, so please review for other starter kits. Thank you.