diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index a0866e1e9..c7d122e15 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,4 +1,4 @@ -name: Code Quality +name: linter on: push: @@ -14,7 +14,7 @@ jobs: quality: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Setup PHP uses: shivammathur/setup-php@v2 @@ -29,7 +29,7 @@ jobs: - name: Run Pint run: vendor/bin/pint - - name: Frontend Format + - name: Frontend Format Check run: npm run format - name: Frontend Lint @@ -39,7 +39,8 @@ jobs: uses: stefanzweifel/git-auto-commit-action@v5 with: commit_message: fix code style - commit_options: "--no-verify" + commit_options: '--no-verify' + # We need to run PHPStan after commiting changes as it does not auto-fix errors. - name: PHPStan run: ./vendor/bin/phpstan diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 0db09cb3d..5af4be3d6 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,7 +16,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup PHP uses: shivammathur/setup-php@v2 @@ -26,7 +26,7 @@ jobs: coverage: xdebug - name: Setup Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: node-version: '18' cache: 'npm' diff --git a/README.md b/README.md index ba6a10f19..31df82e54 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,8 @@

Laravel Logo

-Build Status +Test Status +Lint Status License

diff --git a/app/Http/Controllers/Auth/PasswordResetLinkController.php b/app/Http/Controllers/Auth/PasswordResetLinkController.php index 5e4280b11..14a1b248e 100644 --- a/app/Http/Controllers/Auth/PasswordResetLinkController.php +++ b/app/Http/Controllers/Auth/PasswordResetLinkController.php @@ -6,7 +6,6 @@ use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; use Illuminate\Support\Facades\Password; -use Illuminate\Validation\ValidationException; use Inertia\Inertia; use Inertia\Response; diff --git a/app/Http/Controllers/Auth/VerifyEmailController.php b/app/Http/Controllers/Auth/VerifyEmailController.php index d8f316ebb..2477faa51 100644 --- a/app/Http/Controllers/Auth/VerifyEmailController.php +++ b/app/Http/Controllers/Auth/VerifyEmailController.php @@ -4,7 +4,6 @@ use App\Http\Controllers\Controller; use Illuminate\Auth\Events\Verified; -use Illuminate\Contracts\Auth\MustVerifyEmail; use Illuminate\Foundation\Auth\EmailVerificationRequest; use Illuminate\Http\RedirectResponse; @@ -20,10 +19,9 @@ public function __invoke(EmailVerificationRequest $request): RedirectResponse } if ($request->user()->markEmailAsVerified()) { + /** @var \Illuminate\Contracts\Auth\MustVerifyEmail $user */ $user = $request->user(); - if ($user instanceof MustVerifyEmail) { - event(new Verified($user)); - } + event(new Verified($user)); } return redirect()->intended(route('dashboard', absolute: false).'?verified=1'); diff --git a/resources/js/components/appearance-dropdown.tsx b/resources/js/components/appearance-dropdown.tsx index 0335963bd..89a458620 100644 --- a/resources/js/components/appearance-dropdown.tsx +++ b/resources/js/components/appearance-dropdown.tsx @@ -27,7 +27,7 @@ export default function AppearanceToggleDropdown({ className = '', ...props }: H Toggle theme - + updateAppearance('light')}> diff --git a/resources/js/components/appearance-tabs.tsx b/resources/js/components/appearance-tabs.tsx index 898d2911c..19e39e188 100644 --- a/resources/js/components/appearance-tabs.tsx +++ b/resources/js/components/appearance-tabs.tsx @@ -1,4 +1,5 @@ import { Appearance, useAppearance } from '@/hooks/use-appearance'; +import { cn } from '@/lib/utils'; import { LucideIcon, Monitor, Moon, Sun } from 'lucide-react'; import { HTMLAttributes } from 'react'; @@ -12,16 +13,17 @@ export default function AppearanceToggleTab({ className = '', ...props }: HTMLAt ]; return ( -
+
{tabs.map(({ value, icon: Icon, label }) => (