[4.x] Use property promotion (#586)

* property promotion bits

* Update tests.yml

* god damn full stops

Author: jackbayliss

src/Events/TokenAuthenticated.php

@@ -4,20 +4,12 @@
 
 class TokenAuthenticated
 {
-    /**
-     * The personal access token that was authenticated.
-     *
-     * @var \Laravel\Sanctum\PersonalAccessToken
-     */
-    public $token;
-
     /**
      * Create a new event instance.
      *
-     * @param  \Laravel\Sanctum\PersonalAccessToken  $token
+     * @param  \Laravel\Sanctum\PersonalAccessToken  $token The personal access token that was authenticated.
      */
-    public function __construct($token)
+    public function __construct(public $token)
     {
-        $this->token = $token;
     }
 }

src/Exceptions/MissingAbilityException.php

@@ -7,20 +7,13 @@
 
 class MissingAbilityException extends AuthorizationException
 {
-    /**
-     * The abilities that the user did not have.
-     *
-     * @var array
-     */
-    protected $abilities;
-
     /**
      * Create a new missing scope exception.
      *
-     * @param  array|string  $abilities
+     * @param  array|string  $abilities The abilities that the user did not have.
      * @param  string  $message
      */
-    public function __construct($abilities = [], $message = 'Invalid ability provided.')
+    public function __construct(protected $abilities = [], $message = 'Invalid ability provided.')
     {
         parent::__construct($message);
 

src/Exceptions/MissingScopeException.php

@@ -11,20 +11,13 @@
  */
 class MissingScopeException extends AuthorizationException
 {
-    /**
-     * The scopes that the user did not have.
-     *
-     * @var array
-     */
-    protected $scopes;
-
     /**
      * Create a new missing scope exception.
      *
-     * @param  array|string  $scopes
+     * @param  array|string  $scopes The scopes that the user did not have.
      * @param  string  $message
      */
-    public function __construct($scopes = [], $message = 'Invalid scope(s) provided.')
+    public function __construct(protected $scopes = [], $message = 'Invalid scope(s) provided.')
     {
         parent::__construct($message);
 

src/Guard.php

@@ -9,48 +9,17 @@
 
 class Guard
 {
-    /**
-     * The authentication factory implementation.
-     *
-     * @var \Illuminate\Contracts\Auth\Factory
-     */
-    protected $auth;
-
-    /**
-     * The number of minutes tokens should be allowed to remain valid.
-     *
-     * @var int
-     */
-    protected $expiration;
-
-    /**
-     * The provider name.
-     *
-     * @var string
-     */
-    protected $provider;
-
-    /**
-     * Whether to track the last used timestamp.
-     *
-     * @var bool
-     */
-    protected $trackLastUsedAt;
 
     /**
      * Create a new guard instance.
      *
-     * @param  \Illuminate\Contracts\Auth\Factory  $auth
-     * @param  int  $expiration
-     * @param  string  $provider
-     * @param  bool  $trackLastUsedAt
+     * @param  \Illuminate\Contracts\Auth\Factory  $auth The authentication factory implementation.
+     * @param  int  $expiration The number of minutes tokens should be allowed to remain valid.
+     * @param  string  $provider The provider name.
+     * @param  bool  $trackLastUsedAt Whether to track the last used timestamp.
      */
-    public function __construct(AuthFactory $auth, $expiration = null, $provider = null, $trackLastUsedAt = true)
+    public function __construct(protected AuthFactory $auth, protected $expiration = null, protected $provider = null, protected $trackLastUsedAt = true)
     {
-        $this->auth = $auth;
-        $this->expiration = $expiration;
-        $this->provider = $provider;
-        $this->trackLastUsedAt = $trackLastUsedAt;
     }
 
     /**

src/Http/Middleware/AuthenticateSession.php

@@ -13,21 +13,13 @@
 
 class AuthenticateSession
 {
-    /**
-     * The authentication factory implementation.
-     *
-     * @var \Illuminate\Contracts\Auth\Factory
-     */
-    protected $auth;
-
     /**
      * Create a new middleware instance.
      *
-     * @param  \Illuminate\Contracts\Auth\Factory  $auth
+     * @param  \Illuminate\Contracts\Auth\Factory  $auth The authentication factory implementation.
      */
-    public function __construct(AuthFactory $auth)
+    public function __construct(protected AuthFactory $auth)
     {
-        $this->auth = $auth;
     }
 
     /**

src/NewAccessToken.php

@@ -7,30 +7,14 @@
 
 class NewAccessToken implements Arrayable, Jsonable
 {
-    /**
-     * The access token instance.
-     *
-     * @var \Laravel\Sanctum\PersonalAccessToken
-     */
-    public $accessToken;
-
-    /**
-     * The plain text version of the token.
-     *
-     * @var string
-     */
-    public $plainTextToken;
-
     /**
      * Create a new access token result.
      *
-     * @param  \Laravel\Sanctum\PersonalAccessToken  $accessToken
-     * @param  string  $plainTextToken
+     * @param  \Laravel\Sanctum\PersonalAccessToken  $accessToken The access token instance.
+     * @param  string  $plainTextToken The plain text version of the token.
      */
-    public function __construct(PersonalAccessToken $accessToken, string $plainTextToken)
+    public function __construct(public PersonalAccessToken $accessToken, public string $plainTextToken)
     {
-        $this->accessToken = $accessToken;
-        $this->plainTextToken = $plainTextToken;
     }
 
     /**