[10.x][Algolia] Support numeric 'whereNotIn' to prevent silent failures (#959)

* fix(algolia): support whereNotIn filters in Algolia engine search

* refactor(algolia): improve whereNotIn filter handling and add related tests

Author: sakshamgorey

src/Engines/AlgoliaEngine.php

@@ -133,15 +133,27 @@ protected function filters(Builder $builder)
             ->map(fn ($value, $key) => $key.'='.$value)
             ->values();
 
-        return $wheres->merge(collect($builder->whereIns)->map(function ($values, $key) {
+        $whereIns = collect($builder->whereIns)->map(function ($values, $key) {
             if (empty($values)) {
                 return '0=1';
             }
 
             return collect($values)
                 ->map(fn ($value) => $key.'='.$value)
                 ->all();
-        })->values())->values()->all();
+        })->values();
+
+        $whereNotIns = collect($builder->whereNotIns)->flatMap(function ($values, $key) {
+            if (empty($values)) {
+                return [];
+            }
+
+            return collect($values)
+                ->map(fn ($value) => $key.'!='.$value)
+                ->all();
+        });
+
+        return $wheres->merge($whereIns)->merge($whereNotIns)->values()->all();
     }
 
     /**

tests/Feature/Engines/Algolia3EngineTest.php

@@ -243,4 +243,57 @@ public function test_update_empty_searchable_array_from_soft_deleted_model_does_
 
         unset($_ENV['chirp.toSearchableArray']);
     }
+
+    public function test_search_sends_correct_parameters_to_algolia_for_where_not_in_search()
+    {
+        $engine = $this->app->make(EngineManager::class)->engine();
+        $this->client->shouldReceive('initIndex')->once()->with('users')->andReturn($index = m::mock(stdClass::class));
+
+        $index->shouldReceive('search')->once()->with('zonda', [
+            'numericFilters' => [
+                'foo!=1',
+                'foo!=2',
+            ],
+        ]);
+
+        $builder = new Builder(new SearchableUser, 'zonda');
+        $builder->whereNotIn('foo', [1, 2]);
+
+        $engine->search($builder);
+    }
+
+    public function test_search_ignores_empty_where_not_in_search()
+    {
+        $engine = $this->app->make(EngineManager::class)->engine();
+        $this->client->shouldReceive('initIndex')->once()->with('users')->andReturn($index = m::mock(stdClass::class));
+
+        $index->shouldReceive('search')->once()->with('zonda', []);
+
+        $builder = new Builder(new SearchableUser, 'zonda');
+        $builder->whereNotIn('foo', []);
+
+        $engine->search($builder);
+    }
+
+    public function test_search_sends_correct_parameters_to_algolia_for_mixed_search()
+    {
+        $engine = $this->app->make(EngineManager::class)->engine();
+        $this->client->shouldReceive('initIndex')->once()->with('users')->andReturn($index = m::mock(stdClass::class));
+
+        $index->shouldReceive('search')->once()->with('zonda', [
+            'numericFilters' => [
+                'foo=1',
+                ['bar=1', 'bar=2'],
+                'baz!=1',
+                'baz!=2',
+            ],
+        ]);
+
+        $builder = new Builder(new SearchableUser, 'zonda');
+        $builder->where('foo', 1)
+                ->whereIn('bar', [1, 2])
+                ->whereNotIn('baz', [1, 2]);
+
+        $engine->search($builder);
+    }
 }

tests/Feature/Engines/Algolia4EngineTest.php

@@ -234,4 +234,65 @@ public function test_update_empty_searchable_array_from_soft_deleted_model_does_
 
         unset($_ENV['searchable.chirp']);
     }
+
+    public function test_search_sends_correct_parameters_to_algolia_for_where_not_in_search()
+    {
+        $engine = $this->app->make(EngineManager::class)->engine();
+
+        $this->client->shouldReceive('searchSingleIndex')->once()->with(
+            'users',
+            [
+                'query' => 'zonda',
+                'numericFilters' => [
+                    'foo!=1',
+                    'foo!=2',
+                ],
+            ]
+        );
+
+        $builder = new Builder(new SearchableUser, 'zonda');
+        $builder->whereNotIn('foo', [1, 2]);
+
+        $engine->search($builder);
+    }
+
+    public function test_search_ignores_empty_where_not_in_search()
+    {
+        $engine = $this->app->make(EngineManager::class)->engine();
+
+        $this->client->shouldReceive('searchSingleIndex')->once()->with(
+            'users',
+            ['query' => 'zonda']
+        );
+
+        $builder = new Builder(new SearchableUser, 'zonda');
+        $builder->whereNotIn('foo', []);
+
+        $engine->search($builder);
+    }
+
+    public function test_search_sends_correct_parameters_to_algolia_for_mixed_search()
+    {
+        $engine = $this->app->make(EngineManager::class)->engine();
+
+        $this->client->shouldReceive('searchSingleIndex')->once()->with(
+            'users',
+            [
+                'query' => 'zonda',
+                'numericFilters' => [
+                    'foo=1',
+                    ['bar=1', 'bar=2'],
+                    'baz!=1',
+                    'baz!=2',
+                ],
+            ]
+        );
+
+        $builder = new Builder(new SearchableUser, 'zonda');
+        $builder->where('foo', 1)
+                ->whereIn('bar', [1, 2])
+                ->whereNotIn('baz', [1, 2]);
+
+        $engine->search($builder);
+    }
 }