fix(php-fpm): correct socket creation

While my PR #1514 fixed recreating the FPM configs, it introduced a different issue:

Due to the use of `utilizedPhpVersions()`, the code now also configured the FPM config for the alias `php` version.
This caused it to invoke the configure function with an empty version string and thus overwriting the FPM config for (in my case) the [email protected] config templated with `valet.sock` instead of the correct `valet84.sock`.

The nginx sites that were configured to proxy their requests to the `valet84.sock` then failed because it did not exist anymore.

We fixed this by always including the actual linked PHP version via the `linkedPhp` function. This returns `php8.4` instead of `php`.

`php` is an alias anyway and this also removes another unnecessary service restart call. Previously, this would also try to restart the `php` service via brew which was already restarted through the restart of `[email protected]`, which is an alias in brew.

This also fixes an issue with the previous PR, to correctly symlink `valet.sock` again to the linked PHP version, which we oversaw.

Author: saibotk

cli/Valet/Brew.php

@@ -259,7 +259,7 @@ public function getParsedLinkedPhp(): array
     }
 
     /**
-     * Gets the currently linked formula by identifying the symlink in the hombrew bin directory.
+     * Gets the currently linked formula by identifying the symlink in the homebrew bin directory.
      * Different to ->linkedPhp() in that this will just get the linked directory name,
      * whether that is php, php74 or [email protected].
      */

cli/Valet/PhpFpm.php

@@ -37,7 +37,8 @@ public function install(): void
 
         $this->restart();
 
-        $this->symlinkPrimaryValetSock($phpVersion);
+        $linkedPhpVersion = $this->brew->linkedPhp();
+        $this->symlinkPrimaryValetSock($linkedPhpVersion);
     }
 
     /**
@@ -331,6 +332,6 @@ public function utilizedPhpVersions(): array
                     return $this->normalizePhpVersion(str_replace(['valet', '.sock'], '', $sock));
                 }
             }
-        })->merge([$this->brew->getLinkedPhpFormula()])->filter()->unique()->values()->toArray();
+        })->merge([$this->brew->linkedPhp()])->filter()->unique()->values()->toArray();
     }
 }

tests/PhpFpmTest.php

@@ -122,7 +122,7 @@ public function test_utilized_php_versions()
             '[email protected]',
         ]));
 
-        $brewMock->shouldReceive('getLinkedPhpFormula')->andReturn('[email protected]');
+        $brewMock->shouldReceive('linkedPhp')->andReturn('[email protected]');
 
         $nginxMock->shouldReceive('configuredSites')
             ->once()