Skip to content

Commit f670b62

Browse files
committed
fix(php-fpm): correctly reconfigure all versions
This previously only reapplied the configuration for the linked version. Because it is recommended to run valet install again after a brew upgrade, it is necessary to update all utilized PHP versions. On brew upgrades, some versions received the default www.conf again. This would leave the user with a broken setup until they either call `valet use [email protected]` for all the versions or isolate a site again with the version. This commit fixes the behavior by rerunning the configuration step on all php versions. This is more consistent, because in the next line all utilized PHP versions are also restarted.
1 parent b8f4e49 commit f670b62

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

cli/Valet/PhpFpm.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@ public function install(): void
2727

2828
$this->files->ensureDirExists(VALET_HOME_PATH.'/Log', user());
2929

30-
$phpVersion = $this->brew->linkedPhp();
31-
$this->createConfigurationFiles($phpVersion);
30+
foreach ($this->utilizedPhpVersions() as $phpVersion) {
31+
$this->createConfigurationFiles($phpVersion);
32+
}
3233

3334
// Remove old valet.sock
3435
$this->files->unlink(VALET_HOME_PATH.'/valet.sock');

0 commit comments

Comments
 (0)