method/property renaming

Author: joetannenbaum

app/Contexts/AbstractContext.php

@@ -9,11 +9,7 @@ abstract class AbstractContext
 {
     public array $children = [];
 
-    /**
-     * Whether this context can be found as last result
-     * in findAutocompleting method
-     */
-    public bool $findable = false;
+    public bool $isAbleToAutocomplete = false;
 
     public bool $autocompleting = false;
 
@@ -67,7 +63,7 @@ public function findAutocompleting(?AbstractContext $context = null)
 
     protected function searchForAutocompleting(AbstractContext $context, $checkCurrent = false)
     {
-        if ($checkCurrent && $context->autocompleting && $context->findable) {
+        if ($checkCurrent && $context->autocompleting && $context->isAbleToAutocomplete) {
             return $context;
         }
 

app/Contexts/MethodCall.php

@@ -4,7 +4,7 @@
 
 class MethodCall extends AbstractContext
 {
-    public bool $findable = true;
+    public bool $isAbleToAutocomplete = true;
 
     public ?string $methodName = null;
 

app/Contexts/ObjectValue.php

@@ -4,7 +4,7 @@
 
 class ObjectValue extends AbstractContext
 {
-    public bool $findable = true;
+    public bool $isAbleToAutocomplete = true;
 
     public ?string $className = null;
 

app/Parsers/AbstractParser.php

@@ -55,4 +55,14 @@ public function debug(...$messages)
             echo $this->indent($message) . PHP_EOL;
         }
     }
+
+    protected function parentNodeIs(Node $node, array $nodeClasses): bool
+    {
+        if ($node->getParent() === null) {
+            return false;
+        }
+
+        return in_array(get_class($node->getParent()), $nodeClasses)
+            || $this->parentNodeIs($node->getParent(), $nodeClasses);
+    }
 }

app/Parsers/ArrayCreationExpressionParser.php

@@ -5,7 +5,6 @@
 use App\Contexts\AbstractContext;
 use App\Contexts\ArrayValue;
 use Microsoft\PhpParser\MissingToken;
-use Microsoft\PhpParser\Node;
 use Microsoft\PhpParser\Node\Expression\ArrayCreationExpression;
 use Microsoft\PhpParser\Node\Expression\CallExpression;
 use Microsoft\PhpParser\Node\Expression\ObjectCreationExpression;
@@ -17,26 +16,13 @@ class ArrayCreationExpressionParser extends AbstractParser
      */
     protected AbstractContext $context;
 
-    private function isParentNode(Node $node, array $nodeClasses): bool
-    {
-        if ($node->getParent() !== null) {
-            if (in_array(get_class($node->getParent()), $nodeClasses)) {
-                return true;
-            }
-
-            return $this->isParentNode($node->getParent(), $nodeClasses);
-        }
-
-        return false;
-    }
-
     public function parse(ArrayCreationExpression $node)
     {
         // If array is inside a method, for example Validator::validate(['
-        // then we need to ignore findable for ArrayValue because
+        // then we need to ignore isAbleToAutocomplete for ArrayValue because
         // priority is given to App\Contexts\MethodCall or App\Contexts\ObjectValue
-        if (!$this->isParentNode($node, [CallExpression::class, ObjectCreationExpression::class])) {
-            $this->context->findable = true;
+        if (!$this->parentNodeIs($node, [CallExpression::class, ObjectCreationExpression::class])) {
+            $this->context->isAbleToAutocomplete = true;
         }
 
         $this->context->autocompleting = $node->closeParenOrBracket instanceof MissingToken;