flip logic for clarity

joetannenbaum · joetannenbaum · commit fd031938ac69 · 2025-01-14T12:36:39.000-05:00
diff --git a/app/Contexts/AssignmentValue.php b/app/Contexts/AssignmentValue.php
@@ -18,13 +18,13 @@ public function getValue()
     {
         $child = $this->children[0] ?? null;
 
-        if ($child) {
-            return [
-                'name' => $child->name ?? $child->className ?? null,
-                'type' => $child->type(),
-            ];
+        if (!$child) {
+            return null;
         }
 
-        return null;
+        return [
+            'name' => $child->name ?? $child->className ?? null,
+            'type' => $child->type(),
+        ];
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,13 +18,13 @@ public function getValue()`
`18`	`18`	`{`
`19`	`19`	`$child = $this->children[0] ?? null;`
`20`	`20`
`21`		`- if ($child) {`
`22`		`- return [`
`23`		`- 'name' => $child->name ?? $child->className ?? null,`
`24`		`- 'type' => $child->type(),`
`25`		`- ];`
	`21`	`+ if (!$child) {`
	`22`	`+ return null;`
`26`	`23`	`}`
`27`	`24`
`28`		`- return null;`
	`25`	`+ return [`
	`26`	`+ 'name' => $child->name ?? $child->className ?? null,`
	`27`	`+ 'type' => $child->type(),`
	`28`	`+ ];`
`29`	`29`	`}`
`30`	`30`	`}`