More Fixes

Author: pushpak1300

resources/js/pages/settings/TwoFactor.vue

@@ -31,7 +31,7 @@ const breadcrumbs: BreadcrumbItem[] = [
 ];
 
 const { qrCodeSvg, manualSetupKey } = useTwoFactorAuth();
-const showSetupModal = ref(false);
+const showSetupModal = ref<boolean>(false);
 const setupModalRef = ref<InstanceType<typeof TwoFactorSetupModal>>();
 </script>
 

tests/Feature/Auth/AuthenticationTest.php

@@ -13,7 +13,7 @@ class AuthenticationTest extends TestCase
 
     public function test_login_screen_can_be_rendered()
     {
-        $response = $this->get('/login');
+        $response = $this->get(route('login'));
 
         $response->assertStatus(200);
     }
@@ -22,7 +22,7 @@ public function test_users_can_authenticate_using_the_login_screen()
     {
         $user = User::factory()->create();
 
-        $response = $this->post('/login', [
+        $response = $this->post(route('login'), [
             'email' => $user->email,
             'password' => 'password',
         ]);
@@ -50,12 +50,12 @@ public function test_users_with_two_factor_enabled_are_redirected_to_two_factor_
             'two_factor_confirmed_at' => now(),
         ])->save();
 
-        $response = $this->post('/login', [
+        $response = $this->post(route('login'), [
             'email' => $user->email,
             'password' => 'password',
         ]);
 
-        $response->assertRedirect('/two-factor-challenge');
+        $response->assertRedirect(route('two-factor.login'));
         $response->assertSessionHas('login.id', $user->id);
         $this->assertGuest();
     }
@@ -64,7 +64,7 @@ public function test_users_without_two_factor_enabled_login_normally()
     {
         $user = User::factory()->create();
 
-        $response = $this->post('/login', [
+        $response = $this->post(route('login'), [
             'email' => $user->email,
             'password' => 'password',
         ]);
@@ -78,7 +78,7 @@ public function test_users_can_not_authenticate_with_invalid_password()
     {
         $user = User::factory()->create();
 
-        $this->post('/login', [
+        $this->post(route('login'), [
             'email' => $user->email,
             'password' => 'wrong-password',
         ]);
@@ -90,26 +90,26 @@ public function test_users_can_logout()
     {
         $user = User::factory()->create();
 
-        $response = $this->actingAs($user)->post('/logout');
+        $response = $this->actingAs($user)->post(route('logout'));
 
         $this->assertGuest();
-        $response->assertRedirect('/');
+        $response->assertRedirect(route('home'));
     }
 
     public function test_users_are_rate_limited()
     {
         $user = User::factory()->create();
 
         for ($i = 0; $i < 5; $i++) {
-            $this->post('/login', [
+            $this->post(route('login'), [
                 'email' => $user->email,
                 'password' => 'wrong-password',
             ])->assertStatus(302)->assertSessionHasErrors([
                 'email' => 'These credentials do not match our records.',
             ]);
         }
 
-        $response = $this->post('/login', [
+        $response = $this->post(route('login'), [
             'email' => $user->email,
             'password' => 'wrong-password',
         ]);

tests/Feature/Auth/TwoFactorChallengeTest.php

@@ -81,15 +81,13 @@ public function test_two_factor_authentication_is_rate_limited(): void
         foreach (range(0, 4) as $ignored) {
             $this->post(route('two-factor.login.store'), [
                 'code' => '000000',
-            ])->assertStatus(302)->assertSessionHasErrors([
-                'code' => 'The provided two factor authentication code was invalid.',
-            ]);
+            ])->assertSessionHasErrors('code');
         }
 
         $response = $this->post(route('two-factor.login.store'), [
             'code' => '000000',
         ]);
 
-        $response->assertStatus(429);
+        $response->assertTooManyRequests();
     }
 }