Improve Breadcrumb type and usage (#303)

Co-authored-by: WendellAdriel <11641518+WendellAdriel@users.noreply.github.com>
Co-authored-by: WendellAdriel <me@wendelladriel.com>

Author: joetannenbaum

resources/js/components/Breadcrumbs.vue

@@ -27,9 +27,7 @@ defineProps<Props>();
                     </template>
                     <template v-else>
                         <BreadcrumbLink as-child>
-                            <Link :href="item.href ?? '#'">{{
-                                item.title
-                            }}</Link>
+                            <Link :href="item.href">{{ item.title }}</Link>
                         </BreadcrumbLink>
                     </template>
                 </BreadcrumbItem>

resources/js/pages/Dashboard.vue

@@ -8,7 +8,7 @@ import { dashboard } from '@/routes';
 const breadcrumbs: BreadcrumbItem[] = [
     {
         title: 'Dashboard',
-        href: dashboard().url,
+        href: dashboard(),
     },
 ];
 </script>

resources/js/pages/settings/Appearance.vue

@@ -10,7 +10,7 @@ import { edit } from '@/routes/appearance';
 const breadcrumbItems: BreadcrumbItem[] = [
     {
         title: 'Appearance settings',
-        href: edit().url,
+        href: edit(),
     },
 ];
 </script>

resources/js/pages/settings/Profile.vue

@@ -22,7 +22,7 @@ defineProps<Props>();
 const breadcrumbItems: BreadcrumbItem[] = [
     {
         title: 'Profile settings',
-        href: edit().url,
+        href: edit(),
     },
 ];
 

resources/js/types/navigation.ts

@@ -3,7 +3,7 @@ import type { LucideIcon } from 'lucide-vue-next';
 
 export type BreadcrumbItem = {
     title: string;
-    href?: string;
+    href: NonNullable<InertiaLinkProps['href']>;
 };
 
 export type NavItem = {