refactor: simplify two-factor authentication

Author: pushpak1300

app/Http/Controllers/Settings/TwoFactorAuthenticationController.php

@@ -1,28 +1,34 @@
 <?php
 
-declare(strict_types=1);
-
 namespace App\Http\Controllers\Settings;
 
 use App\Http\Controllers\Controller;
-use App\Models\User;
 use Illuminate\Http\Request;
 use Inertia\Inertia;
 use Inertia\Response;
 
 class TwoFactorAuthenticationController extends Controller
 {
+    /**
+     * Show the user's two-factor authentication settings page.
+     */
     public function show(Request $request): Response
     {
         $user = $request->user();
-        $confirmed = ! is_null($user->two_factor_confirmed_at);
-        $hasTwoFactorSecret = ! is_null($user->two_factor_secret);
+
+        $confirmed = filled($user->two_factor_confirmed_at);
+        $hasSecret = filled($user->two_factor_secret);
+        $showSetup = ! $confirmed && $hasSecret;
+
+        $recoveryCodes = $hasSecret && filled($user->two_factor_recovery_codes)
+            ? (json_decode(decrypt($user->two_factor_recovery_codes), true) ?: [])
+            : [];
 
         return Inertia::render('settings/TwoFactor', [
             'confirmed' => $confirmed,
-            'recoveryCodes' => $hasTwoFactorSecret ? json_decode(decrypt($user->two_factor_recovery_codes)) : [],
-            'qrCodeSvg' => !$confirmed && $hasTwoFactorSecret ? $user->twoFactorQrCodeSvg() : null,
-            'secretKey' => !$confirmed && $hasTwoFactorSecret ? decrypt($user->two_factor_secret) : null,
+            'recoveryCodes' => $recoveryCodes,
+            'qrCodeSvg' => $showSetup ? $user->twoFactorQrCodeSvg() : null,
+            'secretKey' => $showSetup ? decrypt($user->two_factor_secret) : null,
         ]);
     }
 }

tests/Feature/Settings/TwoFactorAuthenticationTest.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 namespace Tests\Feature\Settings;
 
 use App\Models\User;