added tests

Author: joetannenbaum

src/GenerateCommand.php

@@ -154,7 +154,7 @@ private function writeControllerFile(Collection $routes, string $namespace): voi
 
         if ($invokable->isEmpty()) {
             $exportedMethods = $methods->map(fn (Route $route) => $route->jsMethod());
-            $reservedMethods = $methods->filter(fn (Route $route) => $route->originalJsMethod() !== $route->jsMethod())->map(fn (Route $route) => $route->originalJsMethod().': '.$route->jsMethod());
+            $reservedMethods = $methods->filter(fn (Route $route) => $route->originalJsMethod() !== $route->jsMethod())->map(fn (Route $route) => TypeScript::quoteIfNeeded($route->originalJsMethod()).': '.$route->jsMethod());
             $exportedMethods = $exportedMethods->merge($reservedMethods);
 
             $methodProps = "const {$defaultExport} = { ";

src/TypeScript.php

@@ -76,6 +76,19 @@ public static function safeMethod(string $method, string $suffix): string
         return $method;
     }
 
+    public static function quoteIfNeeded(string $name): string
+    {
+        if (is_numeric($name)) {
+            return $name;
+        }
+
+        if (is_numeric($name[0])) {
+            return '"'.$name.'"';
+        }
+
+        return $name;
+    }
+
     public static function cleanUp(string $view): string
     {
         $replacements = [

tests/DisallowedMethodNames.test.ts

@@ -3,6 +3,8 @@ import DisallowedMethodNameController, {
     deleteMethod,
     method404,
 } from "../workbench/resources/js/actions/App/Http/Controllers/DisallowedMethodNameController";
+import method2fa from "../workbench/resources/js/routes/2fa";
+import defaultMethod from "../workbench/resources/js/routes/default";
 import disallowed from "../workbench/resources/js/routes/disallowed";
 
 test("will append `method` to invalid methods", () => {
@@ -17,3 +19,15 @@ test("will append `method` to invalid methods", () => {
 test("will append `method` to invalid methods", () => {
     expect(disallowed[404].url()).toBe("/disallowed/404");
 });
+
+test("will properly handle leading numbers", () => {
+    expect(method2fa.disallowed.url()).toBe("/disallowed/2fa");
+    expect(DisallowedMethodNameController["2fa"].url()).toBe("/disallowed/2fa");
+});
+
+test("will properly handle reserved JS words", () => {
+    expect(defaultMethod.login.url()).toBe("/disallowed/default");
+    expect(DisallowedMethodNameController["default"].url()).toBe(
+        "/disallowed/default",
+    );
+});

workbench/routes/web.php

@@ -67,6 +67,8 @@
 
 Route::get('/disallowed/delete', [DisallowedMethodNameController::class, 'delete']);
 Route::get('/disallowed/404', [DisallowedMethodNameController::class, '404'])->name('disallowed.404');
+Route::get('/disallowed/2fa', [DisallowedMethodNameController::class, '2fa'])->name('2fa.disallowed');
+Route::get('/disallowed/default', [DisallowedMethodNameController::class, 'default'])->name('default.login');
 
 Route::get('/anonymous-middleware', [AnonymousMiddlewareController::class, 'show']);