Merge pull request #51 from laravel/handle-namespaced-routes

Handle namespaced routes correctly

Author: joetannenbaum

src/GenerateCommand.php

@@ -78,9 +78,7 @@ public function handle()
         if (! $this->option('skip-routes')) {
             $this->files->deleteDirectory($this->base());
 
-            $named = $routes->filter(
-                fn (Route $route) => $route->name() && ! Str::endsWith($route->name(), '.') && ! Str::startsWith($route->name(), 'generated::')
-            )->groupBy(fn (Route $route) => $route->name());
+            $named = $routes->filter(fn (Route $route) => $route->name())->groupBy(fn (Route $route) => $route->name());
 
             $named->each($this->writeNamedFile(...));
             $named->undot()->each($this->writeBarrelFiles(...));

src/Route.php

@@ -121,7 +121,17 @@ public function domain(): ?string
 
     public function name(): ?string
     {
-        return $this->base->getName();
+        $name = $this->base->getName();
+
+        if (! $name || Str::endsWith($name, '.') || Str::startsWith($name, 'generated::')) {
+            return null;
+        }
+
+        if (str_contains($name, '::')) {
+            return 'namespaced.'.str_replace('::', '.', $name);
+        }
+
+        return $name;
     }
 
     public function controllerPath(): string

tests/NamedspacedRoute.test.ts

@@ -0,0 +1,10 @@
+import { expect, it } from "vitest";
+import { store } from "../workbench/resources/js/routes/namespaced/my-package";
+
+it("can access a namespaced route", () => {
+    expect(store.url()).toBe("/package-route");
+    expect(store()).toEqual({
+        url: "/package-route",
+        method: "get",
+    });
+});

workbench/routes/web.php

@@ -70,6 +70,10 @@
 
 Route::get('/anonymous-middleware', [AnonymousMiddlewareController::class, 'show']);
 
+Route::get('/package-route', function () {
+    //
+})->name('my-package::store');
+
 Route::prefix('/api/v1')->name('api.v1.')->group(function () {
     Route::get('/tasks', fn () => 'ok')->name('tasks');