Migrate BrowserKit tests to HTTP tests (#984)

* migrate AdminTest from browserkit tests to http tests

* update assertRedirectToRoute() by assertRedirect()

* remove BrowserKit from AdminTest

* update ArticleTest

* update BlockUsersTest

* update CanonicalUrlTest

* update HomeTest

* update ModeratorTest

* update NavigationTest

* update NotificationsTest

* update ProfileTest

* update ReplyTest

* migrate settingsTest

* update AuthTest

* remove RouteServiceProvider from authtest

* update ForumTest

* fix: two failed forum tests

* build: remove browser kit testing depedency

Author: fabiorodriguesroque

composer.json

@@ -41,7 +41,6 @@
     },
     "require-dev": {
         "fakerphp/faker": "^1.10",
-        "laravel/browser-kit-testing": "^7.0",
         "mockery/mockery": "^1.4.4",
         "nunomaduro/collision": "^7.0",
         "pestphp/pest": "^2.0",

tests/Feature/AdminTest.php

@@ -6,14 +6,14 @@
 use App\Models\User;
 use Carbon\Carbon;
 use Illuminate\Foundation\Testing\DatabaseMigrations;
-use Tests\Feature\BrowserKitTestCase;
+use Tests\TestCase;
 
-uses(BrowserKitTestCase::class);
+uses(TestCase::class);
 uses(DatabaseMigrations::class);
 
 test('requires login', function () {
-    $this->visit('/admin')
-        ->seePageIs('/login');
+    $this->get('/admin')
+        ->assertRedirect('/login');
 });
 
 test('normal users cannot visit the admin section', function () {
@@ -83,9 +83,9 @@
     $this->loginAsAdmin();
 
     $this->put('/admin/users/'.$user->username().'/ban')
-        ->assertRedirectedTo('/');
+        ->assertRedirect('/');
 
-    test()->seeInDatabase('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
+    test()->assertDatabaseHas('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
 });
 
 test('moderators cannot ban a user without a reason', function () {
@@ -94,9 +94,9 @@
     $this->loginAsModerator();
 
     $this->put('/admin/users/'.$user->username().'/ban')
-        ->assertRedirectedTo('/');
+        ->assertRedirect('/');
 
-    test()->seeInDatabase('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
+    test()->assertDatabaseHas('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
 });
 
 test('admins can delete a user', function () {
@@ -108,14 +108,14 @@
     $this->loginAsAdmin();
 
     $this->delete('/admin/users/'.$user->username())
-        ->assertRedirectedTo('/admin/users');
+        ->assertRedirect('/admin/users');
 
-    $this->notSeeInDatabase('users', ['name' => 'Freek Murze']);
+    $this->assertDatabaseMissing('users', ['name' => 'Freek Murze']);
 
     // Make sure associated content is deleted.
-    $this->notSeeInDatabase('threads', ['author_id' => $user->id()]);
-    $this->notSeeInDatabase('replies', ['replyable_id' => $thread->id()]);
-    $this->notSeeInDatabase('replies', ['author_id' => $user->id()]);
+    $this->assertDatabaseMissing('threads', ['author_id' => $user->id()]);
+    $this->assertDatabaseMissing('replies', ['replyable_id' => $thread->id()]);
+    $this->assertDatabaseMissing('replies', ['author_id' => $user->id()]);
 });
 
 test('admins cannot delete other admins', function () {
@@ -144,9 +144,9 @@
     $this->loginAsAdmin();
 
     $this->get('admin')
-        ->see($submittedArticle->title())
-        ->dontSee($draftArticle->title())
-        ->dontSee($liveArticle->title());
+        ->assertSee($submittedArticle->title())
+        ->assertDontSee($draftArticle->title())
+        ->assertDontSee($liveArticle->title());
 });
 
 test('moderators can list submitted articles', function () {
@@ -157,9 +157,9 @@
     $this->loginAsModerator();
 
     $this->get('admin')
-        ->see($submittedArticle->title())
-        ->dontSee($draftArticle->title())
-        ->dontSee($liveArticle->title());
+        ->assertSee($submittedArticle->title())
+        ->assertDontSee($draftArticle->title())
+        ->assertDontSee($liveArticle->title());
 });
 
 test('users cannot list submitted articles', function () {
@@ -171,7 +171,7 @@
 
 test('guests cannot list submitted articles', function () {
     $this->get('admin')
-        ->assertRedirectedTo('login');
+        ->assertRedirect('/login');
 });
 
 test('admins can view submitted articles', function () {
@@ -180,7 +180,7 @@
     $this->loginAsAdmin();
 
     $this->get("articles/{$article->slug()}")
-        ->see('Awaiting Approval');
+        ->assertSee('Awaiting Approval');
 });
 
 test('admins can approve articles', function () {
@@ -216,7 +216,7 @@
     $article = Article::factory()->create(['submitted_at' => now()]);
 
     $this->put("/admin/articles/{$article->slug()}/approve")
-        ->assertRedirectedTo('/login');
+        ->assertRedirect('/login');
 
     expect($article->fresh()->approvedAt())->toBeNull();
 });
@@ -254,7 +254,7 @@
     $article = Article::factory()->create(['submitted_at' => now(), 'approved_at' => now()]);
 
     $this->put("/admin/articles/{$article->slug()}/disapprove")
-        ->assertRedirectedTo('/login');
+        ->assertRedirect('/login');
 
     $this->assertNotNull($article->fresh()->approvedAt());
 });
@@ -357,30 +357,30 @@ function assertCanSeeTheUserOverview()
     User::factory()->create(['name' => 'Freek Murze']);
     User::factory()->create(['name' => 'Frederick Vanbrabant']);
 
-    test()->visit('/admin/users')
-        ->see('Freek Murze')
-        ->see('Frederick Vanbrabant');
+    test()->get('/admin/users')
+        ->assertSee('Freek Murze')
+        ->assertSee('Frederick Vanbrabant');
 }
 
 function assertCanBanUsers()
 {
     $user = User::factory()->create(['name' => 'Freek Murze']);
 
     test()->put('/admin/users/'.$user->username().'/ban', ['reason' => 'A good reason'])
-        ->assertRedirectedTo('/user/'.$user->username());
+        ->assertRedirect('/user/'.$user->username());
 
-    test()->notSeeInDatabase('users', ['id' => $user->id(), 'banned_at' => null]);
-    test()->seeInDatabase('users', ['id' => $user->id(), 'banned_reason' => 'A good reason']);
+    test()->assertDatabaseMissing('users', ['id' => $user->id(), 'banned_at' => null]);
+    test()->assertDatabaseHas('users', ['id' => $user->id(), 'banned_reason' => 'A good reason']);
 }
 
 function assertCanUnbanUsers()
 {
     $user = User::factory()->create(['name' => 'Freek Murze', 'banned_at' => Carbon::now()]);
 
     test()->put('/admin/users/'.$user->username().'/unban')
-        ->assertRedirectedTo('/user/'.$user->username());
+        ->assertRedirect('/user/'.$user->username());
 
-    test()->seeInDatabase('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
+    test()->assertDatabaseHas('users', ['id' => $user->id(), 'banned_at' => null, 'banned_reason' => null]);
 }
 
 function assertCannotBanAdmins()