WIP

Author: tauseefsshah

app/Console/Commands/SyncArticleImages.php

@@ -31,7 +31,7 @@ public function handle(): void
 
         Article::published()->chunk(100, function ($articles) {
             $articles->each(function ($article) {
-                if ($article->hasHeroImage()) {
+                if ($this->shouldBeSynced($article)) {
                     $imageData = $this->fetchUnsplashImageDataFromId($article->hero_image);
 
                     if (!is_null($imageData)) {
@@ -45,6 +45,15 @@ public function handle(): void
         });
     }
 
+    protected function shouldBeSynced(Article $article): bool
+    {
+        if ($article->hero_image && ! $article->hasHeroImage()) {
+            return false;
+        }
+
+        return true;
+    }
+
     protected function fetchUnsplashImageDataFromId(string $imageId): ?array
     {
         $response = Http::retry(3, 100, null, false)->withToken($this->accessKey, 'Client-ID')

app/Models/Article.php

@@ -103,7 +103,13 @@ public function excerpt(int $limit = 100): string
 
     public function hasHeroImage(): bool
     {
-        return $this->hero_image !== null;
+        return $this->hero_image_url !== null;
+    }
+
+    public function hasHeroImageAuthor(): bool
+    {
+        return $this->hero_image_author_name !==  null &&
+            $this->hero_image_author_url !== null;
     }
 
     public function heroImage($width = 400, $height = 300): string

resources/views/articles/show.blade.php

@@ -85,7 +85,12 @@ class="w-full bg-center {{ $article->hasHeroImage() ? 'bg-cover' : '' }} bg-gray
                         </div>
                     </div>
                 </div>
-                <p class="text-xs text-black/50 text-center mt-2">Photo by <a class="underline font-medium" href="{{ $article->hero_image_author_url }}?ref=laravel.io" target="_blank">{{ $article->hero_image_author_name }} </a> on <a class="underline font-medium" href="https://unsplash.com/?ref=laravel.io" target="_blank">Unsplash</a></p>
+
+                @if($article->hasHeroImageAuthor())
+                    <p class="text-xs text-black/50 text-center mt-2">
+                        Photo by <a class="underline font-medium" href="{{ $article->hero_image_author_url }}?ref=laravel.io" target="_blank">{{ $article->hero_image_author_name }} </a> on <a class="underline font-medium" href="https://unsplash.com/?ref=laravel.io" target="_blank">Unsplash</a>
+                    </p>
+                @endif
             </div>
         </div>