Unique GitHub Usernames (#981)

* feat: add remove duplicate command

* feat: resolve duplicate github usernames

* feat: add job for resolving duplicate github usernames

* username is required in job

* username is required in job

* remove github username job

* Resolve duplicate github usernames

* wip

* wip

---------

Co-authored-by: Dries Vints <[email protected]>

Author: digitlimit

app/Console/Commands/ResolveDuplicateGithubUsernames.php

@@ -0,0 +1,80 @@
+<?php
+
+namespace App\Console\Commands;
+
+use Illuminate\Console\Command;
+use App\Models\User;
+use Illuminate\Database\Eloquent\Collection;
+use App\Social\GithubUserApi;
+use Exception;
+
+class ResolveDuplicateGithubUsernames extends Command
+{
+    protected $signature = 'lio:resolve-duplicate-github-usernames';
+
+    protected $description = 'Resolve duplicate GitHub usernames from the database';
+
+    public function __construct(private GithubUserApi $github)
+    {
+        parent::__construct();
+    }
+
+    public function handle(): void
+    {
+        $this->info('Resolving duplicate Github usernames...');
+
+        $this->duplicates()
+            ->groupBy('github_username')
+            ->each(function (Collection $users) {
+                $uniqueUsernames = [];
+
+                // Order from the latest user to the oldest
+                $users = $users->sortByDesc('created_at');
+
+                // Resolve each user with the same github_username
+                foreach ($users as $user) {
+                    try {
+                        $githubUser = $this->github->find($user->github_id);
+                    } catch (Exception $e) {
+                        $message = $e->getCode() === 404 ? "Error 404: github_id - $user->github_id" : $e->getMessage();
+                        $this->error($message);
+                        continue;
+                    }
+
+                    // If the user doesn't exist on GitHub
+                    if (! $githubUser || ! $githubUser->login()) {
+                        $user->update(['github_username' => null]);
+                        continue;
+                    }
+
+                    // If the user's github_username marked as unique
+                    if (in_array($githubUser->login(), $uniqueUsernames)) {
+                        $user->update(['github_username' => null]);
+                        continue;
+                    }
+
+                    // If the user exists on GitHub, update the user's github_username
+                    $user->update(['github_username' => $githubUser->login()]);
+
+                    $this->info("Updated user: {$user->id} with github_username: {$githubUser->login()}");
+
+                    // Mark the user's github_username as unique
+                    $uniqueUsernames[] = $githubUser->login();
+                }
+            });
+
+        $this->info('Duplicate Github usernames resolved!');
+    }
+
+    private function duplicates(): Collection
+    {
+        return User::whereIn('github_username', function ($query) {
+            $query->select('github_username')
+                ->from('users')
+                ->whereNotNull('github_username')
+                ->where('github_username', '!=', '')
+                ->groupBy('github_username')
+                ->havingRaw('COUNT(github_username) > 1');
+        })->get();
+    }
+}

app/Listeners/ResolveDuplicateGitHubUsername.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Listeners;
+
+use App\Models\User;
+use App\Social\GithubUserApi;
+use Illuminate\Auth\Events\Registered;
+
+final class ResolveDuplicateGitHubUsername
+{
+    public function __construct(private readonly GithubUserApi $github)
+    {
+    }
+
+    public function handle(Registered $event): void
+    {
+        User::where('github_username', $event->user->github_username)
+            ->whereKeyNot($event->user)
+            ->latest()
+            ->get()
+            ->each(function (User $user) {
+                $user->update([
+                    'github_username' => $this->github->find($user->github_id)?->login(),
+                ]);
+            });
+    }
+}

app/Providers/EventServiceProvider.php

@@ -12,6 +12,7 @@
 use App\Listeners\NotifyUsersMentionedInReply;
 use App\Listeners\NotifyUsersMentionedInThread;
 use App\Listeners\RenewEmailVerificationNotification;
+use App\Listeners\ResolveDuplicateGitHubUsername;
 use App\Listeners\SendArticleApprovedNotification;
 use App\Listeners\SendNewArticleNotification;
 use App\Listeners\SendNewReplyNotification;
@@ -42,6 +43,7 @@ class EventServiceProvider extends ServiceProvider
             RenewEmailVerificationNotification::class,
         ],
         Registered::class => [
+            ResolveDuplicateGitHubUsername::class,
             SendEmailVerificationNotification::class,
         ],
         ReplyWasCreated::class => [

app/Social/GitHubUser.php

@@ -8,9 +8,13 @@
 
 final class GitHubUser implements Arrayable
 {
-    public function __construct(
-        private array $attributes
-    ) {
+    public function __construct(private array $attributes)
+    {
+    }
+
+    public function login(): string
+    {
+        return $this->get('login');
     }
 
     public function hasPublicRepositories(): bool

app/Social/GithubUserApi.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace App\Social;
+
+use Illuminate\Support\Facades\Http;
+use Illuminate\Http\Client\ConnectionException;
+
+class GithubUserApi
+{
+    public function find(int|string $id): ?GitHubUser
+    {
+        $response = Http::retry(3, 100, fn ($exception) => $exception instanceof ConnectionException)
+            ->get("https://api.github.com/user/{$id}");
+
+        return $response->failed() ? null : new GitHubUser($response->json());
+    }
+}