Add GolangCI configuration and update CI permissions. Introduced a new .golangci.yml file to configure linters and exclude specific directories and files from linting. Updated CI workflow permissions to enhance security scanning capabilities.

Author: larkinwc

.github/workflows/ci.yml

@@ -99,6 +99,10 @@ jobs:
   security:
     name: Security Scan
     runs-on: ubuntu-latest
+    permissions:
+      security-events: write
+      actions: read
+      contents: read
     steps:
     - name: Checkout code
       uses: actions/checkout@v4

.golangci.yml

@@ -0,0 +1,108 @@
+linters-settings:
+  golint:
+    min-confidence: 0
+  gocyclo:
+    min-complexity: 15
+  govet:
+    enable:
+      - shadow
+  misspell:
+    locale: US
+  lll:
+    line-length: 140
+  gocritic:
+    enabled-tags:
+      - diagnostic
+      - experimental
+      - opinionated
+      - performance
+      - style
+    disabled-checks:
+      - dupImport
+      - ifElseChain
+      - octalLiteral
+      - whyNoLint
+      - wrapperFunc
+  funlen:
+    lines: 100
+    statements: 50
+
+linters:
+  disable-all: true
+  enable:
+    - gofmt
+    - govet
+    - errcheck
+    - staticcheck
+    - unused
+    - gosimple
+    - ineffassign
+    - typecheck
+    - gosec
+    - unconvert
+    - dupl
+    - goconst
+    - gocyclo
+    - gocognit
+    - asciicheck
+    - misspell
+    - unparam
+    - dogsled
+    - nakedret
+    - prealloc
+    - gocritic
+    - gochecknoinits
+    - whitespace
+    - lll
+    - revive
+    - goimports
+
+issues:
+  exclude-dirs:
+    - vendor
+    - third_party
+    - testdata
+    - examples
+    - build
+    - dist
+  
+  exclude-files:
+    - ".*\\.pb\\.go$"
+    - ".*\\.gen\\.go$"
+    
+  exclude-rules:
+    - path: _test\.go
+      linters:
+        - gocyclo
+        - errcheck
+        - dupl
+        - gosec
+        - lll
+    
+    # Exclude lll issues for long lines with go:generate
+    - linters:
+        - lll
+      source: "^//go:generate "
+
+    # Exclude some staticcheck messages
+    - linters:
+        - staticcheck
+      text: "SA1019:"
+
+    # Exclude exported but undocumented for main packages
+    - path: cmd/
+      linters:
+        - golint
+      text: "exported .* should have comment"
+
+  # Maximum issues count per one linter
+  max-issues-per-linter: 50
+
+  # Maximum count of issues with the same text
+  max-same-issues: 10
+
+  # Show only new issues
+  new: false
+
+run:
+  timeout: 5m

cmd/gitlab-runner-tui/main.go

@@ -9,23 +9,24 @@ import (
 
 	tea "github.com/charmbracelet/bubbletea"
 	"github.com/charmbracelet/lipgloss"
+	"github.com/larkinwc/gitlab-runner-tui/pkg/config"
 	"github.com/larkinwc/gitlab-runner-tui/pkg/runner"
 	"github.com/larkinwc/gitlab-runner-tui/pkg/ui"
 )
 
 type model struct {
-	tabs         []string
-	activeTab    int
-	runnersView  *ui.RunnersView
-	logsView     *ui.LogsView
-	configView   *ui.ConfigView
-	systemView   *ui.SystemView
-	historyView  *ui.HistoryView
-	width        int
-	height       int
-	quitting     bool
-	debugMode    bool
-	initialized  map[int]bool
+	tabs        []string
+	activeTab   int
+	runnersView *ui.RunnersView
+	logsView    *ui.LogsView
+	configView  *ui.ConfigView
+	systemView  *ui.SystemView
+	historyView *ui.HistoryView
+	width       int
+	height      int
+	quitting    bool
+	debugMode   bool
+	initialized map[int]bool
 }
 
 func initialModel(configPath string, debugMode bool) model {
@@ -174,35 +175,35 @@ func (m model) View() string {
 	}
 
 	statusBar := m.renderStatusBar()
-	
+
 	// Calculate available height for content
 	tabBarHeight := lipgloss.Height(tabBar)
 	statusBarHeight := lipgloss.Height(statusBar)
 	availableHeight := m.height - tabBarHeight - statusBarHeight - 1
-	
+
 	// Ensure we have positive height
 	if availableHeight < 1 {
 		availableHeight = 1
 	}
-	
+
 	// Ensure content doesn't overflow
 	contentLines := strings.Split(content, "\n")
 	if len(contentLines) > availableHeight && availableHeight > 0 {
 		content = strings.Join(contentLines[:availableHeight], "\n")
 	}
-	
+
 	// Calculate padding
 	contentHeight := lipgloss.Height(content)
 	paddingHeight := m.height - tabBarHeight - contentHeight - statusBarHeight
 	if paddingHeight < 0 {
 		paddingHeight = 0
 	}
-	
+
 	padding := ""
 	if paddingHeight > 0 {
 		padding = strings.Repeat("\n", paddingHeight)
 	}
-	
+
 	return lipgloss.JoinVertical(
 		lipgloss.Left,
 		tabBar,
@@ -232,18 +233,18 @@ func (m model) renderStatusBar() string {
 		Background(ui.ColorPrimary).
 		Foreground(ui.ColorBg).
 		Padding(0, 1)
-		
+
 	helpStyle := lipgloss.NewStyle().
 		Background(ui.ColorSecondary).
 		Foreground(ui.ColorBg).
 		Padding(0, 1)
-		
+
 	// Build contextual help based on active tab
 	var commands []string
-	
+
 	// Global commands
 	commands = append(commands, "Tab/Shift+Tab: Switch tabs", "1-5: Jump to tab", "q: Quit")
-	
+
 	// Tab-specific commands
 	switch m.activeTab {
 	case 0: // Runners
@@ -257,17 +258,17 @@ func (m model) renderStatusBar() string {
 	case 4: // History
 		commands = append(commands, "↑/↓: Navigate", "r: Refresh")
 	}
-	
+
 	// Add debug mode indicator if enabled
 	statusText := ""
 	if m.debugMode {
 		statusText = " [DEBUG] "
 	}
-	
+
 	// Combine status and help
 	status := statusStyle.Render(statusText + m.tabs[m.activeTab])
 	help := helpStyle.Render(strings.Join(commands, " • "))
-	
+
 	// Fill the remaining width
 	statusBarContent := lipgloss.JoinHorizontal(lipgloss.Top, status, " ", help)
 	remainingWidth := m.width - lipgloss.Width(statusBarContent)
@@ -277,42 +278,40 @@ func (m model) renderStatusBar() string {
 			Render(strings.Repeat(" ", remainingWidth))
 		statusBarContent = lipgloss.JoinHorizontal(lipgloss.Top, statusBarContent, filler)
 	}
-	
+
 	return statusBarContent
 }
 
 func main() {
 	var configPath string
 	var debugMode bool
 	var showHelp bool
-	
-	defaultConfig := "/etc/gitlab-runner/config.toml"
-	
-	flag.StringVar(&configPath, "config", defaultConfig, "Path to GitLab Runner config file")
+
+	flag.StringVar(&configPath, "config", config.DefaultConfigPath, "Path to GitLab Runner config file")
 	flag.BoolVar(&debugMode, "debug", false, "Enable debug mode for verbose logging")
 	flag.BoolVar(&showHelp, "help", false, "Show help information")
 	flag.BoolVar(&showHelp, "h", false, "Show help information")
-	
+
 	flag.Usage = func() {
 		fmt.Fprintf(os.Stderr, "GitLab Runner TUI - Terminal User Interface for managing GitLab runners\n\n")
 		fmt.Fprintf(os.Stderr, "Usage: %s [options]\n\n", os.Args[0])
 		fmt.Fprintf(os.Stderr, "Options:\n")
 		flag.PrintDefaults()
 		fmt.Fprintf(os.Stderr, "\nDefault config paths checked:\n")
-		fmt.Fprintf(os.Stderr, "  1. %s (system-wide)\n", defaultConfig)
+		fmt.Fprintf(os.Stderr, "  1. %s (system-wide)\n", config.DefaultConfigPath)
 		fmt.Fprintf(os.Stderr, "  2. $HOME/.gitlab-runner/config.toml (user-specific)\n")
 		fmt.Fprintf(os.Stderr, "\nIf no config is found at the default path, the user-specific path is tried.\n")
 	}
-	
+
 	flag.Parse()
-	
+
 	if showHelp {
 		flag.Usage()
 		os.Exit(0)
 	}
 
 	// Check if config exists at specified path
-	if configPath == defaultConfig {
+	if configPath == config.DefaultConfigPath {
 		if _, err := os.Stat(configPath); os.IsNotExist(err) {
 			altPath := os.ExpandEnv("$HOME/.gitlab-runner/config.toml")
 			if _, err := os.Stat(altPath); err == nil {

cmd/gitlab-runner-tui/main_test.go

@@ -116,11 +116,11 @@ func TestModelSwitchTab(t *testing.T) {
 	// Test switching to uninitialized tab
 	m.activeTab = 1
 	newModel, cmd := m.switchTab()
-	
+
 	if !newModel.initialized[1] {
 		t.Error("Tab 1 should be marked as initialized")
 	}
-	
+
 	if cmd == nil {
 		t.Error("Expected init command for uninitialized tab")
 	}
@@ -129,7 +129,7 @@ func TestModelSwitchTab(t *testing.T) {
 	m.initialized[2] = true
 	m.activeTab = 2
 	newModel, cmd = m.switchTab()
-	
+
 	if cmd != nil {
 		t.Error("Expected no command for already initialized tab")
 	}
@@ -215,4 +215,4 @@ func (m *mockRunnerService) GetJobHistory(limit int) ([]runner.Job, error) {
 	return []runner.Job{}, nil
 }
 
-func (m *mockRunnerService) SetDebugMode(enabled bool) {}
+func (m *mockRunnerService) SetDebugMode(enabled bool) {}