feat: enhance configuration handling and validation

- Added error logging for missing specified config files in `initConfig`.
- Updated `ps` command to load and validate configuration from a specified file, defaulting to `lxc-compose.yml`.
- Included configuration validation in the `up` command to ensure proper setup before container management.
- Enhanced integration tests to check for invalid configuration handling.
- Updated example `lxc-compose.yml` to include versioning for better compatibility.

Author: larkinwc

cmd/lxc-compose/main.go

@@ -53,6 +53,10 @@ func initConfig() {
 
 	if err := viper.ReadInConfig(); err == nil {
 		logging.Info("Using config file", "path", viper.ConfigFileUsed())
+	} else if cfgFile != "" {
+		// If a specific config file was requested but not found, that's an error
+		logging.Error("Failed to read specified config file", "path", cfgFile, "error", err)
+		os.Exit(1)
 	}
 }
 

cmd/lxc-compose/ps.go

@@ -5,6 +5,7 @@ import (
 	"os"
 	"text/tabwriter"
 
+	"github.com/larkinwc/proxmox-lxc-compose/pkg/config"
 	"github.com/larkinwc/proxmox-lxc-compose/pkg/container"
 
 	"github.com/spf13/cobra"
@@ -14,7 +15,26 @@ func init() {
 	var psCmd = &cobra.Command{
 		Use:   "ps",
 		Short: "List containers",
-		RunE: func(_ *cobra.Command, _ []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
+			// Get config file from flag or use default
+			configFile := cmd.Flag("config").Value.String()
+			if configFile == "" {
+				configFile = "lxc-compose.yml"
+			}
+
+			// Load and validate configuration if file exists
+			if _, err := os.Stat(configFile); err == nil {
+				cfg, err := config.Load(configFile)
+				if err != nil {
+					return fmt.Errorf("failed to load config: %w", err)
+				}
+
+				// Validate configuration
+				if err := config.ValidateConfig(cfg); err != nil {
+					return fmt.Errorf("configuration validation failed: %w", err)
+				}
+			}
+
 			// Create container manager
 			manager, err := container.NewLXCManager("/var/lib/lxc")
 			if err != nil {

cmd/lxc-compose/up.go

@@ -36,6 +36,11 @@ func upCmdRunE(_ *cobra.Command, args []string) error {
 		return fmt.Errorf("failed to load config: %w", err)
 	}
 
+	// Validate configuration
+	if err := config.ValidateConfig(cfg); err != nil {
+		return fmt.Errorf("configuration validation failed: %w", err)
+	}
+
 	// Create container manager
 	manager, err := container.NewLXCManager("/var/lib/lxc")
 	if err != nil {

integration-test/docker-lxc/advanced-test.sh

@@ -32,6 +32,9 @@ fi
 
 # Test invalid config (if exists)
 if [ -f "invalid-config.yml" ]; then
+    echo "Testing with invalid-config.yml:"
+    cat invalid-config.yml | head -3
+    echo "..."
     if /var/tmp/lxc-compose --config invalid-config.yml ps >/dev/null 2>&1; then
         echo "⚠️  Invalid configuration accepted (should fail)"
     else

integration-test/docker-lxc/test-data/lxc-compose.yml

@@ -1,3 +1,4 @@
+version: "3"
 services:
   web:
     image: "ubuntu:20.04"

pkg/container/manager.go

@@ -90,12 +90,21 @@ func (m *LXCManager) execLXCCommand(name string, args ...string) error {
 		}
 
 		if err != nil {
-			logging.Error("Command failed",
-				"command", name,
-				"args", args,
-				"output", string(output),
-				"error", err,
-			)
+			// Use debug level for expected failures like container non-existence
+			if name == "lxc-info" && strings.Contains(string(output), "doesn't exist") {
+				logging.Debug("Container does not exist (expected)",
+					"command", name,
+					"args", args,
+					"output", string(output),
+				)
+			} else {
+				logging.Error("Command failed",
+					"command", name,
+					"args", args,
+					"output", string(output),
+					"error", err,
+				)
+			}
 			return fmt.Errorf("command failed: %w", err)
 		}
 		return nil