Skip to content

Commit 6e0bf10

Browse files
committed
made large 1D arrays display faster by not creating the filter combobox for axes >= 10000 elements (issue #93)
1 parent 599d46d commit 6e0bf10

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

larray_editor/arraywidget.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -771,7 +771,12 @@ def set_data(self, data=None, bg_value=None):
771771
filters_layout.addWidget(QLabel(_("Filters")))
772772
for axis, display_name in zip(axes, display_names):
773773
filters_layout.addWidget(QLabel(display_name))
774-
filters_layout.addWidget(self.create_filter_combo(axis))
774+
# FIXME: on very large axes, this is getting too slow. Ideally the combobox should use a model which
775+
# only fetch labels when they are needed to be displayed
776+
if len(axis) < 10000:
777+
filters_layout.addWidget(self.create_filter_combo(axis))
778+
else:
779+
filters_layout.addWidget(QLabel("too big to be filtered"))
775780
filters_layout.addStretch()
776781
self.data_adapter.update_filtered_data({})
777782

0 commit comments

Comments
 (0)