Skip to content

Commit 75a4a7f

Browse files
committed
when using the scrollwheel on filter comboboxes, only emit one signal (issue #93)
(so that we compute & redraw the new visible data only once)
1 parent 737883f commit 75a4a7f

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

larray_editor/combo.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,14 +115,14 @@ def on_model_item_changed(self, item):
115115
else:
116116
model[0].checked = 'partial'
117117
model.blockSignals(False)
118-
is_checked = [i for i, item in enumerate(model[1:]) if item.checked]
119-
self.checkedItemsChanged.emit(is_checked)
118+
checked_indices = [i for i, item in enumerate(model[1:]) if item.checked]
119+
self.checkedItemsChanged.emit(checked_indices)
120120

121121
def select_offset(self, offset):
122122
"""offset: 1 for next, -1 for previous"""
123123

124124
model = self._model
125-
# model.blockSignals(True)
125+
model.blockSignals(True)
126126
indices_checked = [i for i, item in enumerate(model) if item.checked]
127127
first_checked = indices_checked[0]
128128
# check first_checked + offset, uncheck the rest
@@ -135,6 +135,8 @@ def select_offset(self, offset):
135135
is_checked = ["partial"] + [i == to_check for i in range(1, len(model))]
136136
for checked, item in zip(is_checked, model):
137137
item.checked = checked
138+
model.blockSignals(False)
139+
self.checkedItemsChanged.emit([to_check - 1])
138140

139141
def addItem(self, text):
140142
item = StandardItem(text)

0 commit comments

Comments
 (0)