CLN: fixed lint warnings reported by ruff

Author: gdementen

larray_editor/__init__.py

@@ -1,3 +1,3 @@
-from larray_editor.api import *
+from larray_editor.api import *  # noqa: F403
 
 __version__ = '0.34-dev'

larray_editor/api.py

@@ -75,8 +75,8 @@ def _find_names(obj, depth=0):
         computed an array just to view it.
     """
     # noinspection PyProtectedMember
-    l = sys._getframe(depth + 1).f_locals
-    names = [k for k, v in l.items() if v is obj]
+    local_vars = sys._getframe(depth + 1).f_locals
+    names = [k for k, v in local_vars.items() if v is obj]
     if any(not name.startswith('_') for name in names):
         names = [name for name in names if not name.startswith('_')]
     return sorted(names)
@@ -274,7 +274,7 @@ def _get_debug_except_hook(root_path=None, usercode_traceback=True, usercode_fra
 
     def excepthook(type, value, tback):
         # first try to go as far as the main module because in some cases (e.g. when we run the file via a debugger),
-        # the top of the traceback is not always the main module)
+        # the top of the traceback is not always the main module
         current_tb = tback
         while current_tb.tb_next and _trace_code_file(current_tb) != main_file:
             current_tb = current_tb.tb_next

larray_editor/arrayadapter.py

@@ -7,6 +7,7 @@
 
 REGISTERED_ADAPTERS = {}
 
+
 def register_adapter(type):
     """Class decorator to register new adapter
 
@@ -362,8 +363,8 @@ def to_excel(self, raw_data, axes_names, vlabels, hlabels):
             # convert (row) generators to lists then array
             # TODO: the conversion to array is currently necessary even though xlwings will translate it back to a list
             #       anyway. The problem is that our lists contains numpy types and especially np.str_ crashes xlwings.
-            #       unsure how we should fix this properly: in xlwings, or change _selection_data to return only standard
-            #       Python types.
+            #       unsure how we should fix this properly: in xlwings, or change _selection_data to return only
+            #       standard Python types.
             array = np.array([list(r) for r in data])
             wb = la.open_excel()
             wb[0]['A1'] = array

larray_editor/arraywidget.py

@@ -868,7 +868,6 @@ def set_format(self, frac_digits=None, scientific=None):
         assert frac_digits is None or isinstance(frac_digits, int)
         assert scientific is None or isinstance(scientific, bool)
         scientific_toggled = scientific is not None and scientific != self.use_scientific
-        compute_new_width = not scientific_toggled
         if logger.isEnabledFor(logging.DEBUG):
             logger.debug(f"ArrayEditorWidget.set_format(frac_digits={frac_digits}, scientific={scientific})")
 
@@ -1032,7 +1031,7 @@ def create_filter_combo(self, axis):
         def filter_changed(checked_items):
             self.change_filter(axis, checked_items)
         combo = FilterComboBox(self)
-        combo.addItems([str(l) for l in axis.labels])
+        combo.addItems([str(label) for label in axis.labels])
         combo.checkedItemsChanged.connect(filter_changed)
         return combo
 

larray_editor/comparator.py

@@ -1,5 +1,4 @@
 import ast
-import warnings
 
 import numpy as np
 import larray as la

larray_editor/tests/test_adapter.py

@@ -1,11 +1,7 @@
 import pytest
 
-import numpy as np
 import larray as la
 
-from larray_editor.utils import Product
-from larray_editor.arraymodel import DataArrayModel, LARGE_NROWS, LARGE_COLS
-
 
 @pytest.fixture(scope="module")
 def data():

larray_editor/tests/test_api_larray.py

@@ -1,12 +1,13 @@
 """Array editor test"""
 
 import logging
-from pathlib import Path
+# from pathlib import Path
 
 import numpy as np
 import larray as la
 
-from larray_editor.api import *
+from larray_editor.api import edit
+# from larray_editor.api import view, edit, debug, compare
 from larray_editor.utils import logger
 
 import qtpy