Skip to content

Commit 3de198d

Browse files
committed
simplified FileHandler._read_item by returning only the value, not the key
(the key wasn't used anywhere)
1 parent 1e42342 commit 3de198d

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed

larray/inout/common.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,7 @@ def read(self, keys, *args, **kwargs):
127127
if display:
128128
print("loading", type, "object", key, "...", end=' ')
129129
try:
130-
key, item = self._read_item(key, type, *args, **kwargs)
131-
res[key] = item
130+
res[key] = self._read_item(key, type, *args, **kwargs)
132131
except Exception:
133132
if not ignore_exceptions:
134133
raise

larray/inout/csv.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -342,11 +342,11 @@ def list_items(self):
342342

343343
def _read_item(self, key, type, *args, **kwargs):
344344
if type == 'Array':
345-
return key, read_csv(self._to_filepath(key), *args, **kwargs)
345+
return read_csv(self._to_filepath(key), *args, **kwargs)
346346
elif type == 'Axis':
347-
return key, self.axes[key]
347+
return self.axes[key]
348348
elif type == 'Group':
349-
return key, self.groups[key]
349+
return self.groups[key]
350350
else:
351351
raise TypeError()
352352

larray/inout/excel.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -282,11 +282,11 @@ def list_items(self):
282282
def _read_item(self, key, type, *args, **kwargs):
283283
if type == 'Array':
284284
df = self.handle.parse(key, *args, **kwargs)
285-
return key, df_aslarray(df, raw=True)
285+
return df_aslarray(df, raw=True)
286286
elif type == 'Axis':
287-
return key, self.axes[key]
287+
return self.axes[key]
288288
elif type == 'Group':
289-
return key, self.groups[key]
289+
return self.groups[key]
290290
else:
291291
raise TypeError()
292292

@@ -386,11 +386,11 @@ def list_items(self):
386386

387387
def _read_item(self, key, type, *args, **kwargs):
388388
if type == 'Array':
389-
return key, self.handle[key].load(*args, **kwargs)
389+
return self.handle[key].load(*args, **kwargs)
390390
elif type == 'Axis':
391-
return key, self.axes[key]
391+
return self.axes[key]
392392
elif type == 'Group':
393-
return key, self.groups[key]
393+
return self.groups[key]
394394
else:
395395
raise TypeError()
396396

larray/inout/hdf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def _read_item(self, key, type, *args, **kwargs):
132132
kwargs['name'] = key
133133
else:
134134
raise TypeError()
135-
return key, read_hdf(self.handle, hdf_key, *args, **kwargs)
135+
return read_hdf(self.handle, hdf_key, *args, **kwargs)
136136

137137
def _dump_item(self, key, value, *args, **kwargs):
138138
if isinstance(value, LArray):

larray/inout/pickle.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ def list_items(self):
3434
return items
3535

3636
def _read_item(self, key, type, *args, **kwargs):
37-
if type in ['Array', 'Axis', 'Group']:
38-
return key, self.data[key]
37+
if type in {'Array', 'Axis', 'Group'}:
38+
return self.data[key]
3939
else:
4040
raise TypeError()
4141

0 commit comments

Comments
 (0)