fix #713 : fixed maximum length of sheet names (31 characters instead of 30 characters) when adding a new sheet to an Excel Workbook

Author: alixdamman

doc/source/changes/version_0_30.rst.inc

@@ -178,3 +178,6 @@ Fixes
 -----
 
 * fixed LArray.divnot0 being slow when the divisor has many axes and many zeros (closes :issue:`705`).
+
+* fixed maximum length of sheet names (31 characters instead of 30 characters) when adding a new sheet
+  to an Excel Workbook (closes :issue:`713`).

larray/core/group.py

@@ -657,7 +657,7 @@ def _translate_sheet_name(sheet_name):
         sheet_name = str(_to_tick(sheet_name))
     if isinstance(sheet_name, basestring):
         sheet_name = _sheet_name_pattern.sub('_', sheet_name)
-        if len(sheet_name) > 30:
+        if len(sheet_name) > 31:
             raise ValueError("Sheet names cannot exceed 31 characters")
     return sheet_name
 

larray/tests/test_array.py

@@ -3870,6 +3870,12 @@ def test_to_excel_xlwings(tmpdir):
     assert sheet_names == sorted(['a0', 'a1', 'a2', 'a3', 'c0,c2', 'c0__2', 'even',
                                   '_name_with_special___char_'])
 
+    # sheet name of 31 characters (= maximum authorized length)
+    a3.to_excel(fpath, "sheetname_of_exactly_31_chars__", engine='xlwings')
+    # sheet name longer than 31 characters
+    with pytest.raises(ValueError, message="Sheet names cannot exceed 31 characters"):
+        a3.to_excel(fpath, "sheetname_longer_than_31_characters", engine='xlwings')
+
 
 def test_as_table():
     res = list(ndtest(3).as_table(wide=False, value_name='data'))