print all lines if maxlines=-1

Author: alixdamman

doc/source/changes/version_0_30.rst.inc

@@ -259,6 +259,7 @@ Miscellaneous improvements
 
   Closes :issue:`274`.
 
+
 Fixes
 -----
 

larray/core/array.py

@@ -2296,14 +2296,13 @@ def as_table(self, maxlines=-1, edgeitems=5, light=False, wide=True, value_name=
         Parameters
         ----------
         maxlines : int, optional
-            Maximum number of lines to show. If negative all lines are shown.
-            Defaults to -1.
+            Maximum number of lines to show. Defaults to -1 (all lines are shown).
         edgeitems : int, optional
             If number of lines to display is greater than `maxlines`,
             only the first and last `edgeitems` lines are displayed.
-            Only active if `maxlines` is not 0.
+            Only active if `maxlines` is not -1.
             Defaults to 5.
-        light: bool, optional
+        light : bool, optional
             Whether or not printing the array in the same way as a pandas DataFrame with a MultiIndex
             (see example below). Defaults to False.
         wide : boolean, optional
@@ -2385,7 +2384,7 @@ def as_table(self, maxlines=-1, edgeitems=5, light=False, wide=True, value_name=
         other_colnames = self.axes[-1].labels.tolist() if wide else [value_name]
         yield axes_names + other_colnames
         # summary if needed
-        if maxlines > 0 and height > maxlines:
+        if maxlines >= 0 and height > maxlines:
             # replace middle lines of the table by '...'.
             # We show only the first and last edgeitems lines.
             startticks = islice(ticks, edgeitems)

larray/util/options.py

@@ -20,16 +20,16 @@
 }
 
 
-def _integer(value):
-    if not isinstance(value, int):
-        raise ValueError("Expected integer")
-
-
 def _positive_integer(value):
     if not (isinstance(value, int) and value > 0):
         raise ValueError("Expected positive integer")
 
 
+def _integer_maxlines(value):
+    if not isinstance(value, int) and value >= -1:
+        raise ValueError("Expected integer")
+
+
 def _positive_integer_or_none(value):
     if value is None:
         return
@@ -40,7 +40,7 @@ def _positive_integer_or_none(value):
 _VALIDATORS = {
     DISPLAY_PRECISION: _positive_integer_or_none,
     DISPLAY_WIDTH: _positive_integer,
-    DISPLAY_MAXLINES: _integer,
+    DISPLAY_MAXLINES: _integer_maxlines,
     DISPLAY_EDGEITEMS: _positive_integer,
 }
 
@@ -53,11 +53,11 @@ class set_options(object):
 
     - ``display_precision``: number of digits of precision for floating point output.
     - ``display_width``: maximum display width for ``repr`` on larray objects. Defaults to 80.
-    - ``display_maxlines``: Maximum number of lines to show. If 0 all lines are shown.
+    - ``display_maxlines``: Maximum number of lines to show. All lines are shown if -1.
       Defaults to 200.
     - ``display_edgeitems`` : if number of lines to display is greater than ``display_maxlines``,
       only the first and last ``display_edgeitems`` lines are displayed.
-      Only active if ``display_maxlines`` is not 0. Defaults to 5.
+      Only active if ``display_maxlines`` is not -1. Defaults to 5.
 
     Examples
     --------