Invite @mttbernardini as a collaborator? #157
Replies: 3 comments
-
it's conventional to wait with that until some useful contributions are merged. but i don't understand the argument anyway. for review it doesn't matter which repo a PR comes from. and for pushing the PR, it doesn't matter much which repo the branch lives in, either (*). and i think we agreed that we're not going to make non-trivial direct pushes any more? (*) the one situation where it matters is when the maintainers want to update the contributor's branch directly, but the contrib can grant such write access. |
Beta Was this translation helpful? Give feedback.
-
I agree with Oswald that it is a bit quick. To me it makes sense to handle this pull request and later consider granting collaborator status. I can imagine that adding CI requires such a status, which would be a reason to grant it after the PR on the build system is accepted. |
Beta Was this translation helpful? Give feedback.
-
Hey all. I really appreciate the invite as collaborator to the project. However I share the thought of @ossilator and @RonaldAJ: I technically don't need collaborator access to share my contributions, and I'm more than happy to keep the current workflow. In theory even CI doesn't require collabtorator access, so we could re-evaluate later if really needed. ✌️ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I'd like to invite @mttbernardini as a collaborator - working from a single repo is maybe easier for all of us.
0 votes ·
Beta Was this translation helpful? Give feedback.
All reactions