bps unit tests and precommit fixes

Author: memalhot

.github/workflows/precommit.yaml

@@ -8,12 +8,12 @@ jobs:
   pre-commit:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-python@v5
+      - uses: actions/checkout@v5
+      - uses: actions/setup-python@v6
         with:
           python-version: "3.10"
       - name: Set up uv
-        uses: astral-sh/setup-uv@v5
+        uses: astral-sh/setup-uv@v7
       - name: Install dependencies
         run: |
           uv sync --all-groups

br.py

@@ -261,9 +261,9 @@ def log_job_output(job_name: str, *, wait: bool, timeout: int | None) -> None:
             phase = get_pod_status(pod_name)
             if phase in ("Succeeded", "Failed"):
                 print(f"Pod, {pod_name} finished with phase={phase}")
-                end = time.monotonic()
+                # end = time.monotonic()
                 # for logging information
-                elapsed = end - start
+                # elapsed = end - start
                 break
             if timeout and (time.monotonic() - start) > timeout:
                 print(f"Timeout waiting for pod {pod_name} to complete")

tests/test_bps.py

@@ -7,27 +7,31 @@
 from bps import ListPodsCommand, summarize_gpu_pods
 
 
-def create_pod(name: str, namespace: str, node: str, phase: str, gpu_count: int) -> mock.Mock:
+def create_pod(
+    name: str, namespace: str, node: str, phase: str, gpu_count: int
+) -> mock.Mock:
     """Helper to create a properly structured mock pod object."""
     pod = mock.Mock()
-    
+
     pod.model = mock.Mock()
     pod.model.metadata = mock.Mock()
     pod.model.metadata.name = name
     pod.model.metadata.namespace = namespace
-    
+
     pod.model.status = mock.Mock()
     pod.model.status.phase = phase
-    
+
     pod.model.spec = mock.Mock()
     pod.model.spec.nodeName = node
-    
+
     container = mock.Mock()
     container.resources = mock.Mock()
-    container.resources.requests = {"nvidia.com/gpu": gpu_count} if gpu_count > 0 else {}
-    
+    container.resources.requests = (
+        {"nvidia.com/gpu": gpu_count} if gpu_count > 0 else {}
+    )
+
     pod.model.spec.containers = [container]
-    
+
     return pod
 
 
@@ -135,16 +139,19 @@ def test_multiple_pods_same_node(args: argparse.Namespace, capsys):
         assert "default/pod-1" in captured.out
         assert "default/pod-2" in captured.out
 
+
 def test_summarize_gpu_pods_empty():
     result = summarize_gpu_pods([], verbose=False)
     assert result == []
 
+
 def test_summarize_gpu_pods_with_gpu():
     pods = [create_pod("test-pod", "default", "node-a", "Running", 2)]
     result = summarize_gpu_pods(pods, verbose=False)
     assert len(result) == 1
     assert "node-a: BUSY 2 default/test-pod" in result[0]
 
+
 def test_summarize_gpu_pods_multiple_containers():
     # base pod with one GPU container
     pod = create_pod("multi-gpu-pod", "default", "node-a", "Running", 1)
@@ -166,7 +173,8 @@ def test_list_pods_openshift_exception(args: argparse.Namespace, capsys):
     with mock.patch("openshift_client.selector") as mock_selector:
         with mock.patch("openshift_client.timeout"):
             import openshift_client as oc
+
             mock_selector.side_effect = oc.OpenShiftPythonException("Connection failed")
-            
+
             with pytest.raises(SystemExit):
-                ListPodsCommand.run(args)
+                ListPodsCommand.run(args)