Skip to content

Commit 56f42d1

Browse files
Merge pull request #24 from henrywhitaker3/renovate/github.com-go-echarts-go-echarts-v2-2.x
2 parents d2c2d19 + 5056391 commit 56f42d1

File tree

4 files changed

+22
-7
lines changed

4 files changed

+22
-7
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ toolchain go1.23.6
77
require (
88
github.com/DataDog/datadog-api-client-go/v2 v2.26.0
99
github.com/expr-lang/expr v1.16.9
10-
github.com/go-echarts/go-echarts/v2 v2.3.3
10+
github.com/go-echarts/go-echarts/v2 v2.5.0
1111
github.com/hako/durafmt v0.0.0-20210608085754-5c1018a4e16b
1212
github.com/henrywhitaker3/flow v1.10.0
1313
github.com/labstack/echo-contrib v0.17.2

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
1313
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
1414
github.com/expr-lang/expr v1.16.9 h1:WUAzmR0JNI9JCiF0/ewwHB1gmcGw5wW7nWt8gc6PpCI=
1515
github.com/expr-lang/expr v1.16.9/go.mod h1:8/vRC7+7HBzESEqt5kKpYXxrxkr31SaO8r40VO/1IT4=
16-
github.com/go-echarts/go-echarts/v2 v2.3.3 h1:uImZAk6qLkC6F9ju6mZ5SPBqTyK8xjZKwSmwnCg4bxg=
17-
github.com/go-echarts/go-echarts/v2 v2.3.3/go.mod h1:56YlvzhW/a+du15f3S2qUGNDfKnFOeJSThBIrVFHDtI=
16+
github.com/go-echarts/go-echarts/v2 v2.5.0 h1:P/JGanoIrpOOC4K9sRFeKSIUTIpPQwGHQJ/ELWre19Y=
17+
github.com/go-echarts/go-echarts/v2 v2.5.0/go.mod h1:56YlvzhW/a+du15f3S2qUGNDfKnFOeJSThBIrVFHDtI=
1818
github.com/goccy/go-json v0.10.2 h1:CrxCmQqYDkv1z7lO7Wbh2HN93uovUHgrECaO5ZrCXAU=
1919
github.com/goccy/go-json v0.10.2/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MGFi0w8I=
2020
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=

internal/resources/views/charts.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ func GenerateLineChart(series collector.Series, maxPoints int) (string, error) {
6666
line := charts.NewLine()
6767

6868
yopts := opts.YAxis{
69-
Show: false,
69+
Show: opts.Bool(true),
7070
Type: "value",
7171
}
7272
if series.Query.BoolValue {
@@ -83,11 +83,11 @@ func GenerateLineChart(series collector.Series, maxPoints int) (string, error) {
8383
}),
8484
charts.WithYAxisOpts(yopts),
8585
charts.WithXAxisOpts(opts.XAxis{
86-
Show: false,
86+
Show: opts.Bool(true),
8787
Type: "time",
8888
}),
8989
charts.WithLegendOpts(opts.Legend{
90-
Show: false,
90+
Show: opts.Bool(false),
9191
}),
9292
)
9393

@@ -96,8 +96,14 @@ func GenerateLineChart(series collector.Series, maxPoints int) (string, error) {
9696
line.SetXAxis(nil).
9797
AddSeries("Metric", getYAxis(cd)).
9898
SetSeriesOptions(
99-
charts.WithLineChartOpts(opts.LineChart{Smooth: true, Color: "#5c6848"}),
99+
charts.WithLineChartOpts(opts.LineChart{
100+
Smooth: opts.Bool(true),
101+
ShowSymbol: opts.Bool(false),
102+
}),
100103
charts.WithAreaStyleOpts(opts.AreaStyle{Opacity: 0.2, Color: "#5c6848"}),
104+
charts.WithLineStyleOpts(opts.LineStyle{
105+
Color: "#5c6848",
106+
}),
101107
)
102108

103109
cr := newChartRenderer(line, line.Validate)

internal/resources/views/renderer.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"html/template"
66
"io"
77

8+
"github.com/go-echarts/go-echarts/v2/render"
89
chartrender "github.com/go-echarts/go-echarts/v2/render"
910
)
1011

@@ -58,3 +59,11 @@ func (r *chartRenderer) Render(w io.Writer) error {
5859
err := tpl.ExecuteTemplate(w, tplName, r.c)
5960
return err
6061
}
62+
63+
func (r *chartRenderer) RenderContent() []byte {
64+
panic("not implemented")
65+
}
66+
67+
func (r *chartRenderer) RenderSnippet() render.ChartSnippet {
68+
panic("not implemented")
69+
}

0 commit comments

Comments
 (0)