Rework KinesisSettings #976
etspaceman
started this conversation in
Ideas
Replies: 1 comment
-
@etspaceman can you check the #1030 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello -
KinesisSettings
seems to be responsible for two things today:ConfigsBuilder
I propose separating these notions. This should go a long way to cleaning up the API as well. For example, today we have two primary
create
methods:ConfigsBuilder
that the KCL providesThe issue here is if a user elects to use a
schedulerFactory
create method, then they are again forced to provideKinesisSettings
when runningreadFromStream
, most of which the configuration was already provided in theschedulerFactory
setup. It is cumbersome.Separating these notions would allow users to create a consumer via a
schedulerFactory
, and only have to provide the queue's buffer size.Beta Was this translation helpful? Give feedback.
All reactions