Using before_save instead of after_update callback ?

[itkin]

Hello,

Was playing around with your gem (btw thanks amazing work !) , was wondering why you rely on after_update/create callbacks of version creation, instead of relying on the standard rails callback progation (ie instanciate the version in a before_save cb of the versioned instance and let rails save it with its parent in the same commit).

Do you guys see some drawbacks with the described behavior, which made you code the creation feature the way you did ?

thx !!

[JonMidhir]

I suspect it's because you can't ensure the version-creating callback will be executed after all user-defined callbacks.

I worked on Redcrumbs and we had a similar problem.

A user-defined callback could change properties of the model after the version has been created, leading to an inaccurate version being recorded. For that reason it's important to capture the state of the model right after persistence.

[itkin]

i guess so, but asking users to call the AR versioned class method after the model's callbacks have been defined may solve this problem...

Furthermore it would alow users to better control the recorded version by accessing it before it is saved (adding some field to the version, removing some modifications, etc..)

I walked around this issue and used the code "as is" lacking of time, but it may be worth give it a try according to me ...

[JonMidhir]

I'm not sure that would work, you would still have problems with assignment of primary keys, foreign keys, around_filter etc. IMHO It's better to capture the object exactly as it's represented in the database after a save event.

I guess you could monkey patch the VestalVersions:Version class to introduce different behaviour?